Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FastForward Before #6

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Add FastForward Before #6

merged 5 commits into from
Jan 24, 2020

Conversation

valentinbonneaud
Copy link
Collaborator

Add option to the fastForward function to return the occurrence before the given date

Copy link

@ThHareau ThHareau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

I have some minor comments, nothing dangerous

lib/Recur/RRuleIterator.php Show resolved Hide resolved
tests/VObject/Recur/FastForwardTest.php Outdated Show resolved Hide resolved
lib/Recur/RRuleIterator.php Outdated Show resolved Hide resolved
Copy link

@ThHareau ThHareau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quailty is way nicer indeed.

I added to small comments

lib/Recur/RRuleIterator.php Outdated Show resolved Hide resolved
lib/Recur/RRuleIterator.php Show resolved Hide resolved
@valentinbonneaud valentinbonneaud merged commit be709bc into master Jan 24, 2020
@ThHareau ThHareau deleted the feat/fastForwardBefore branch January 30, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants