Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FastForward to end #7

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Add FastForward to end #7

merged 1 commit into from
Jan 24, 2020

Conversation

valentinbonneaud
Copy link
Collaborator

@valentinbonneaud valentinbonneaud commented Jan 23, 2020

Add function to fast forward the recurrence rule to the last generated occurrence.

Linked with #6

Improvements (count is using the old method, until is using the new FF method):
Fast forward to end count yearly basic -> took 72.21ms
Fast forward to end until yearly basic -> took 0.233ms

Fast forward to end count yearly by year day -> took 322.662ms
Fast forward to end until yearly by year day -> took 0.773ms

Fast forward to end count yearly advanced -> took 407.867ms
Fast forward to end until yearly advanced -> took 1.562ms

Fast forward to end count monthly basic -> took 27.834ms
Fast forward to end until monthly basic -> took 0.116ms

Fast forward to end count monthly 31th day -> took 76.878ms
Fast forward to end until monthly 31th day -> took 0.455ms

Fast forward to end count monthly advanced -> took 803.925ms
Fast forward to end until monthly advanced -> took 6.568ms

Fast forward to end count daily basic -> took 212.458ms
Fast forward to end until daily basic -> took 0.097ms

Fast forward to end count daily advanced -> took 225.942ms
Fast forward to end until daily advanced -> took 0.534ms

Fast forward to end count hourly basic -> took 140.776ms
Fast forward to end until hourly basic -> took 0.058ms

Copy link

@ThHareau ThHareau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good. It can be merged it once #6 is merged

@valentinbonneaud valentinbonneaud changed the base branch from master to feat/fastForwardBefore January 24, 2020 14:25
@valentinbonneaud valentinbonneaud changed the base branch from feat/fastForwardBefore to master January 24, 2020 18:15
@valentinbonneaud valentinbonneaud merged commit d78a3ac into master Jan 24, 2020
@ThHareau ThHareau deleted the feat/fastForwardToEnd branch January 30, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants