Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTT-1807-P1: discard emptyVAST and invalidVAST bids detected by VAST unwrap module #933

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

pm-viral-vala
Copy link
Collaborator

Description

Please add change description or link to ticket, docs, etc.

Checklist:

  • PR commit list is unique (rebase/pull with the origin branch to keep master clean).
  • JIRA number is added in the PR title and the commit message.
  • Updated the header-bidding repo with appropiate commit id.
  • Documented the new changes.

For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade

Copy link
Collaborator

@ashishshinde-pubm ashishshinde-pubm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pm-viral-vala pm-viral-vala merged commit c8c0012 into ci Oct 9, 2024
2 checks passed
Pubmatic-Dhruv-Sonone added a commit that referenced this pull request Oct 16, 2024
* UOE-11191: Refactor: consume StoreURL from New portal UI and forward appstoreurl and appsource for applovinmax (#925)

* UOE-11191: Refactor: consume StoreURL from New portal UI and forward appstoreurl and appsource for applovinmax

* review comment

* UOE-11185: Stats for parsing failed for ituneid

* go fmt update

* OTT-1807-P1: discard emptyVAST and invalidVAST bids detected by VAST unwrap module (#933)

Co-authored-by: ashishshinde-pubm <109787960+ashishshinde-pubm@users.noreply.github.com>
Co-authored-by: supriya-patil <supriya.patil@pubmatic.com>
Co-authored-by: dhruv.sonone <dhruv.sonone@pubmatic.com>

* UOE-11098: Pass user.ext.sessionduration and user.ext.impdepth ORTB request to OW partners (#922)

* UOE-11168: Consume then Remove `app.id` from ApplovinMax Request (#931)

* UOE-11322: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp (#935)

* UOE-11322: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp

* test case name update

* comment

* review comment

* UOE-11355: bug fix- AppLovinMax: sendburl is getting passed at imp.ext instead of req.ext (#940)

* UOE-11310: ApplovinMax Signal data not visible in the wakanda logs (#936)

* UOE-11326: Multiimpression request not logger in case one of the bid is rejected because of invalid mapping (#937)

* UOE-11339: Bug fix- Default Bid is not getting formed for Prebid S2S (#941)

* UOE-11339: Bug fix- Default Bid is not getting formed for Prebid S2S

* test cases

* comment

* review comment

* pip install fix

* Fixing semgrp

* Semgrep fix

* Semgrep fix

* Changing ubuntu version

---------

Co-authored-by: PubMatic-OpenWrap <UOEDev@pubmatic.com>
Co-authored-by: pm-avinash-kapre <112699665+AvinashKapre@users.noreply.github.com>
Co-authored-by: Viral Vala <63396712+pm-viral-vala@users.noreply.github.com>
Co-authored-by: ashishshinde-pubm <109787960+ashishshinde-pubm@users.noreply.github.com>
Co-authored-by: supriya-patil <supriya.patil@pubmatic.com>
Co-authored-by: Pubmatic-Supriya-Patil <131644110+Pubmatic-Supriya-Patil@users.noreply.github.com>
Co-authored-by: Saurabh Narkhede <108730956+pm-saurabh-narkhede@users.noreply.github.com>
Co-authored-by: pm-priyanka-bagade <156899734+pm-priyanka-bagade@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants