Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build test #945

Merged
merged 16 commits into from
Oct 16, 2024
Merged

Build test #945

merged 16 commits into from
Oct 16, 2024

Conversation

Pubmatic-Dhruv-Sonone
Copy link
Collaborator

Description

Please add change description or link to ticket, docs, etc.

Checklist:

  • PR commit list is unique (rebase/pull with the origin branch to keep master clean).
  • JIRA number is added in the PR title and the commit message.
  • Updated the header-bidding repo with appropiate commit id.
  • Documented the new changes.

For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade

PubMatic-OpenWrap and others added 15 commits October 8, 2024 14:59
@PubMatic-OpenWrap
Merge pull request #934 from PubMatic-OpenWrap/master
dee6692 
Downmerge_Release_08th_October_2024
@AvinashKapre
UOE-11191: Refactor: consume StoreURL from New portal UI and forward …
131439b 
…appstoreurl and appsource for applovinmax (#925)

* UOE-11191: Refactor: consume StoreURL from New portal UI and forward appstoreurl and appsource for applovinmax

* review comment

* UOE-11185: Stats for parsing failed for ituneid

* go fmt update
@pm-viral-vala @ashishshinde-pubm
@Pubmatic-Supriya-Patil @Pubmatic-Dhruv-Sonone
OTT-1807-P1: discard emptyVAST and invalidVAST bids detected by VAST …
c8c0012 
…unwrap module (#933)

Co-authored-by: ashishshinde-pubm <109787960+ashishshinde-pubm@users.noreply.github.com>
Co-authored-by: supriya-patil <supriya.patil@pubmatic.com>
Co-authored-by: dhruv.sonone <dhruv.sonone@pubmatic.com>
@Pubmatic-Supriya-Patil
UOE-11098: Pass user.ext.sessionduration and user.ext.impdepth ORTB r…
47cef0e 
…equest to OW partners (#922)
@pm-saurabh-narkhede
UOE-11168: Consume then Remove app.id from ApplovinMax Request (#931)
08d2867
@AvinashKapre
UOE-11322: Forward displaymanager and displaymanagerver from app exte…
07dac81 
…nsion to pubmatic ssp (#935)

* UOE-11322: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp

* test case name update

* comment

* review comment
@AvinashKapre
UOE-11355: bug fix- AppLovinMax: sendburl is getting passed at imp.ex…
dc19862 
…t instead of req.ext (#940)
@pm-priyanka-bagade
UOE-11310: ApplovinMax Signal data not visible in the wakanda logs (#936
ff936e2 
)
@Pubmatic-Supriya-Patil
UOE-11326: Multiimpression request not logger in case one of the bid …
2a6d84d 
…is rejected because of invalid mapping (#937)
@AvinashKapre
UOE-11339: Bug fix- Default Bid is not getting formed for Prebid S2S (#…
e8de580 
…941)

* UOE-11339: Bug fix- Default Bid is not getting formed for Prebid S2S

* test cases

* comment

* review comment
@Pubmatic-Dhruv-Sonone
pip install fix
78d8d52
@Pubmatic-Dhruv-Sonone
Fixing semgrp
517b5e1
@Pubmatic-Dhruv-Sonone
Semgrep fix
30f5258
@Pubmatic-Dhruv-Sonone
Semgrep fix
30726d8
@Pubmatic-Dhruv-Sonone
Changing ubuntu version
d0eb46d
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d0eb46d

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:110:	MakeRequests				95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:268:	buildMultiFloorRequests			95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:306:	buildAdapterRequest			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:329:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:372:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:384:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:392:	parseImpressionObject			93.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:506:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:511:	extractPubmaticExtFromRequest		94.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:579:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:597:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:621:	MakeBids				89.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:712:	trimSuffixWithPattern			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:716:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:738:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:750:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:763:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:778:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:828:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:841:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:861:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:870:	getDisplayManagerAndVer			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				94.0%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 76b4593

pubmatic

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:110:	MakeRequests				95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:268:	buildMultiFloorRequests			95.7%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:306:	buildAdapterRequest			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:329:	validateAdSlot				91.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:372:	assignBannerSize			80.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:384:	assignBannerWidthAndHeight		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:392:	parseImpressionObject			93.3%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:506:	roundToFourDecimals			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:511:	extractPubmaticExtFromRequest		94.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:579:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:597:	addKeywordsToExt			92.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:621:	MakeBids				89.6%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:712:	trimSuffixWithPattern			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:716:	getNativeAdm				90.9%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:738:	getMapFromJSON				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:750:	populateFirstPartyDataImpAttributes	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:763:	populateAdUnitKey			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:778:	populateDctrKey				85.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:828:	getStringArray				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:841:	getBidType				100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:861:	Builder					100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic.go:870:	getDisplayManagerAndVer			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:24:	getTargetingKeys			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:36:	copySBExtToBidExt			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:55:	prepareMetaObject			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v2/adapters/pubmatic/pubmatic_ow.go:92:	renameTransparencyParamsKey		87.5%
total:											(statements)				94.0%

@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone merged commit f33f473 into master-1 Oct 16, 2024
2 checks passed
@Pubmatic-Dhruv-Sonone Pubmatic-Dhruv-Sonone deleted the build-test branch October 17, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Pubmatic-Dhruv-Sonone @PubMatic-OpenWrap @AvinashKapre @pm-viral-vala @Pubmatic-Supriya-Patil @pm-saurabh-narkhede @pm-priyanka-bagade