Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce team and player registration limits #228

Closed
tabascq opened this issue Jan 31, 2019 · 1 comment
Closed

Enforce team and player registration limits #228

tabascq opened this issue Jan 31, 2019 · 1 comment
Assignees
@tabascq

Comments

@tabascq
Copy link
Contributor

tabascq commented Jan 31, 2019

Currently all registration limits are zero and so we clearly aren't enforcing a thing. We should start.

We should also set up defaults for new events.

    public int MaxNumberOfTeams { get; set; }
    public int MaxTeamSize { get; set; }
    public int MaxExternalsPerTeam { get; set; }
@tabascq tabascq self-assigned this Feb 4, 2019
tabascq pushed a commit to tabascq/mainpuzzleserver that referenced this issue Feb 5, 2019
@kenny-young
Team Registration Limits (PuzzleServer#228)
cc7cbaa 
Applying limits on number of teams, number of players, and number of externals per team.

Admins have god powers and can add teams over the limit, players over the limit, and externals over the limit - but players cannot.

[We aren't validating the employee aliases but we could choose to manually audit them if desired.]
tabascq added a commit that referenced this issue Feb 6, 2019
@tabascq
Team Registration Limits (#228) (#233)
37d322b 
* Team Registration Limits (#228)

Applying limits on number of teams, number of players, and number of externals per team.

Admins have god powers and can add teams over the limit, players over the limit, and externals over the limit - but players cannot.

[We aren't validating the employee aliases but we could choose to manually audit them if desired.]

* review changes and merge fix

* added a comment
@tabascq
Copy link
Contributor Author

tabascq commented Feb 6, 2019

Addressed with #233

@tabascq tabascq closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabascq tabascq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tabascq