Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Registration Limits (#228) #233

Merged

Conversation

tabascq
Copy link
Contributor

@tabascq tabascq commented Feb 5, 2019

Applying limits on number of teams, number of players, and number of externals per team.

Admins have god powers and can add teams over the limit, players over the limit, and externals over the limit - but players cannot.

[We aren't validating the employee aliases but we could choose to manually audit them if desired.]

Applying limits on number of teams, number of players, and number of externals per team.

Admins have god powers and can add teams over the limit, players over the limit, and externals over the limit - but players cannot.

[We aren't validating the employee aliases but we could choose to manually audit them if desired.]
Copy link
Contributor

@jenetlan jenetlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and I love that you went the extra mile to share the logic between both team list pages - thank you!

ServerCore/Pages/Teams/Index.cshtml Outdated Show resolved Hide resolved
ServerCore/Pages/Teams/Index.cshtml Show resolved Hide resolved
ServerCore/Pages/Teams/TeamListBase.cs Show resolved Hide resolved
@tabascq tabascq merged commit 37d322b into PuzzleServer:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants