Azure Deployment Logic #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds logic required to deploy to Azure using Continuous Deployment. * Yaml updates
asyasky
force-pushed
the
AddAzureEnvironmentCheck
branch
from
e2870fd
to
c387d1e
Compare
added 4 commits
March 6, 2019 22:01
morganbr
requested changes
Mar 10, 2019
ServerCore/Program.cs
Outdated
| .UseStartup<Startup>() | ||
| .Build(); | ||
| WebHost.CreateDefaultBuilder(args) | ||
| //.ConfigureAppConfiguration((ctx, builder) => |
There was a problem hiding this comment.
Should this be cleaned up?
There was a problem hiding this comment.
I think it'll be recreated if I pick "add KeyVault" again in the future, so should be safe to delete.
| <_SavePWD>True</_SavePWD> | ||
| <_DestinationType>AzureWebSite</_DestinationType> | ||
| <InstallAspNetCoreSiteExtension>False</InstallAspNetCoreSiteExtension> | ||
| <KeyVaultUri>https://PuzzleServerTestKeyVault.vault.azure.net</KeyVaultUri> |
There was a problem hiding this comment.
Will this change with the region change?
There was a problem hiding this comment.
No, but we're not using it anyway.
ServerCore/Startup.cs
Outdated
| { | ||
| app.UseBrowserLink(); | ||
| app.UseDeveloperExceptionPage(); | ||
| PuzzleServerContext.UpdateDatabase(app); | ||
| } | ||
| else if (env.IsProduction() && Environment.GetEnvironmentVariable("WEBSITE_SITE_NAME") == "Puzzlehunt") | ||
| { | ||
| app.UseBrowserLink(); |
There was a problem hiding this comment.
We probably don't need this in production or staging
| (options => options.UseLazyLoadingProxies() | ||
| .UseSqlServer(configuration.GetConnectionString("PuzzleServerSQLConnectionString"))); | ||
| } | ||
| else if (env.IsProduction() && Environment.GetEnvironmentVariable("WEBSITE_SITE_NAME") == "puzzlehunt") |
There was a problem hiding this comment.
Why are we checking site name instead of just the environment for these?
There was a problem hiding this comment.
Because when I did only the environment I had problems.
morganbr
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the changes required to have a manual Azure deployment to the test deploy (the automated CI changes will be partly on the VSTS side, so they aren't included).