Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove __init__.py requirement #1696

Merged
merged 11 commits into from
Aug 2, 2023
Merged

Conversation

krpatter-intc
Copy link
Contributor

@krpatter-intc krpatter-intc commented Jul 18, 2023

Closes #1605

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b694685
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/64c94ee65562a500081eac6e
😎 Deploy Preview https://deploy-preview-1696--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@messense
Copy link
Member

I'm not opposed to support this, to get it merged we need to add a test case.

@krpatter-intc
Copy link
Contributor Author

I'm not opposed to support this, to get it merged we need to add a test case.

Thank you. I'll look in to the existing tests and see if there's something I can leverage.

@Marlin-Na
Copy link

+1 for this PR. For test, should we just remove the __init__.py file in the pyo3-mixed-src test example?

@krpatter-intc
Copy link
Contributor Author

should we just remove the init.py file in the pyo3-mixed-src test example?

I couldn't quite figure out why the original tests were failing online. I went with this suggestion for now. I could create a new "pyo3-mixed-without-init" based on the "pyo3-mixed" if that is preferred.

@krpatter-intc
Copy link
Contributor Author

I could create a new "pyo3-mixed-without-init" based on the "pyo3-mixed" if that is preferred.

I went this way and added a new pyo3_mix_implicit test with the specific use case (and the original failures seemed to have gone away after rebasing on main)

@krpatter-intc
Copy link
Contributor Author

Sorry for the push thrash @messense, but I think this is complete. It adds a new test for implicit namespaces and updates the changelog (let me know if squashing is needed in the PR vs. doing in the merge)

@messense messense merged commit 4f173f1 into PyO3:main Aug 2, 2023
@krpatter-intc krpatter-intc deleted the implicit_namespaces branch August 2, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for implicit namespace packages
3 participants