-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove __init__.py requirement #1696
Conversation
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'm not opposed to support this, to get it merged we need to add a test case. |
Thank you. I'll look in to the existing tests and see if there's something I can leverage. |
+1 for this PR. For test, should we just remove the |
b8c80d6
to
474ca73
Compare
I couldn't quite figure out why the original tests were failing online. I went with this suggestion for now. I could create a new "pyo3-mixed-without-init" based on the "pyo3-mixed" if that is preferred. |
I went this way and added a new pyo3_mix_implicit test with the specific use case (and the original failures seemed to have gone away after rebasing on main) |
Sorry for the push thrash @messense, but I think this is complete. It adds a new test for implicit namespaces and updates the changelog (let me know if squashing is needed in the PR vs. doing in the merge) |
Closes #1605