Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create subinterpreter example #3508

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Create subinterpreter example #3508

merged 1 commit into from
Nov 26, 2023

Conversation

mejrs
Copy link
Member

@mejrs mejrs commented Oct 12, 2023

I wrote up most of this when I was thinking about how we can support these in pyo3. I figured I might as well share it.

@mejrs mejrs added the CI-skip-changelog Skip checking changelog entry label Oct 12, 2023
davidhewitt
davidhewitt reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is cool to see! When it's laid out like this, it doesn't seem so hard right? Just need to figure out how to get our nice safe high-level wrappers to be sound under these conditions 😂

examples/sequential/requirements-dev.txt Outdated Show resolved Hide resolved
@davidhewitt davidhewitt mentioned this pull request Oct 20, 2023
Merged
@davidhewitt davidhewitt force-pushed the sub2 branch 2 times, most recently from 1708cc5 to 4436dc9 Compare November 24, 2023 22:39
davidhewitt
davidhewitt approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this and fixed CI, looks good to me, will merge!

@davidhewitt davidhewitt added this pull request to the merge queue Nov 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2023
@davidhewitt
Copy link
Member

Fixed up for MSRV.

@davidhewitt davidhewitt added this pull request to the merge queue Nov 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2023
@davidhewitt davidhewitt added this pull request to the merge queue Nov 26, 2023
Merged via the queue into PyO3:main with commit 0f34fcd Nov 26, 2023
36 checks passed
@mejrs
Copy link
Member Author

mejrs commented Nov 26, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold left review comments

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mejrs @davidhewitt @adamreichold