examples: remove requirements-dev.txt files #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Oct 20, 2023
There was a problem hiding this comment.
Dead file no longer needed.
davidhewitt
commented
Oct 20, 2023
| @@ -1,3 +1,4 @@ | |||
| variable::set("PYO3_VERSION", "0.20.0"); | |||
| file::rename(".template/Cargo.toml", "Cargo.toml"); | |||
| file::rename(".template/pyproject.toml", "pyproject.toml"); | |||
There was a problem hiding this comment.
This was missing from the template, thought I would fix at the same time while touching up these examples.
davidhewitt
force-pushed
the
maturin-build-args
branch
from
07d8d8a to
aaa1d6d
Compare
davidhewitt
force-pushed
the
maturin-build-args
branch
from
aaa1d6d to
7ceb552
Compare
davidhewitt
force-pushed
the
maturin-build-args
branch
from
7ceb552 to
391687d
Compare
|
@adamreichold I'm going to assume this is good to merge now that I switched to use the |
adamreichold
approved these changes
Oct 29, 2023
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #3508 and #3052 we've noticed that we have a bit of duplication of maturin requirements as well as some inconsistency in how we install / pin maturin versions in the examples.
This PR attempts to fix that by removing the
requirements-dev.txtfiles, and moving any "dev" requirements as optional dependencies in thepyproject.tomlfiles. Finally, thenoxfiles are changed to use--config-settingsto pass arguments to maturin in a PEP517 install rather than by callingmaturin develop, meaning those calls also go through the maturin version configured in thepyproject.toml.