-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new bound API instead of .as_ref(py) #3853
Conversation
CodSpeed Performance ReportMerging #3853 will degrade performances by 16.65%Comparing 🎉 Hooray!
|
Benchmark | main |
LilyFoote:replace-as-ref-with-bind |
Change | |
---|---|---|---|---|
⚡ | mapping_from_dict |
355.6 ns | 300 ns | +18.52% |
❌ | extract_float_downcast_success |
425.6 ns | 508.9 ns | -16.38% |
❌ | extract_float_extract_success |
417.2 ns | 500.6 ns | -16.65% |
⚡ | sequence_from_list |
355.6 ns | 300 ns | +18.52% |
`to_str` is not available before Python 3.10 on the limited api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I marked a few spots, where I think we can relax lifetime constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to clean these up, thanks! Just a few small thoughts... 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tidy up, LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! 🚀
I was looking into the step of marking
Py::as_ref
as deprecated and while there's still some blockers, I was able to update to use the new api in a bunch of places.