Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyTypeMethods trait with qualname method #3854

Closed
wants to merge 1 commit into from

Conversation

LilyFoote
Copy link
Contributor

This allows calling Bound<'py, PyType>::qualname().

This allows calling `Bound<'py, PyType>::qualname()`.
Copy link

codspeed-hq bot commented Feb 17, 2024

CodSpeed Performance Report

Merging #3854 will degrade performances by 16.65%

Comparing LilyFoote:qualname-bound (291145f) with main (c33d330)

🎉 Hooray! codspeed-rust just leveled up to 2.3.3!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 3 regressions
✅ 76 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main LilyFoote:qualname-bound Change
extract_float_downcast_success 425.6 ns 508.9 ns -16.38%
extract_float_extract_success 417.2 ns 500.6 ns -16.65%
sequence_from_tuple 232.8 ns 260.6 ns -10.66%

@LilyFoote
Copy link
Contributor Author

Ah! I just had another look at #3853 and I think that covers this.

@LilyFoote LilyFoote closed this Feb 17, 2024
@davidhewitt
Copy link
Member

Maybe you meant #3705 ?

@LilyFoote
Copy link
Contributor Author

Oops! Yes I did!

@LilyFoote LilyFoote deleted the qualname-bound branch February 18, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants