Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SlashCommandGroup treat optional arguments bug #1386

Merged
merged 1 commit into from
May 26, 2022
Merged

Fix SlashCommandGroup treat optional arguments bug #1386

merged 1 commit into from
May 26, 2022

Conversation

yoggys
Copy link
Contributor

@yoggys yoggys commented May 25, 2022

Summary

Fix for issue #1385

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (rebase) May 25, 2022 20:10
@Lulalaby Lulalaby requested review from Dorukyum and plun1331 May 25, 2022 20:10
@Lulalaby Lulalaby added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge with rebase labels May 25, 2022
@Lulalaby Lulalaby linked an issue May 25, 2022 that may be closed by this pull request
Commands in the SlashCommandGroup treat optional arguments as required #1385
Closed
3 tasks
@Lulalaby Lulalaby merged commit b22f45b into Pycord-Development:master May 26, 2022
@yoggys yoggys changed the title Fix #1385 Fix SlashCommandGroup treat optional arguments bug May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@krittick krittick krittick approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

@yoggys yoggys

Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commands in the SlashCommandGroup treat optional arguments as required
4 participants
@yoggys @krittick @Lulalaby @plun1331