Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SlashCommandGroup treat optional arguments bug #1386

Merged
merged 1 commit into from
May 26, 2022
Merged

Fix SlashCommandGroup treat optional arguments bug #1386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions discord/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,9 @@ def _parse_options(self, params, *, check_params: bool = True) -> List[Option]:
option = Option(p_obj.default)
elif isinstance(p_obj.default, Option) and not (default := p_obj.default.default) is None:
option.default = default
else:
option.default = p_obj.default
option.required = False
if option.name is None:
option.name = p_name
if option.name != p_name or option._parameter_name is None:
Expand Down