Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New discord.Thread additions #1447

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

baronkobama
Copy link
Contributor

Summary

This PR adds the thread attribute to discord.Message which represents the thread created from the message, if any. This part is mostly a resurrection of the stale/closed #850. Atop of this, the starting_message property is added to discord.Thread which returns the message which started the thread. A few consistency changes to dashes and a docstring are made as well.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum
Copy link
Member

Should message.thread be set to None when a thread is deleted?

@Lulalaby
Copy link
Member

Yeah

@baronkobama
Copy link
Contributor Author

Should message.thread be set to None when a thread is deleted?

Good catch, done.

@Dorukyum Dorukyum enabled auto-merge (squash) June 30, 2022 12:10
@Dorukyum Dorukyum merged commit 08d7f91 into Pycord-Development:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants