Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread attribute to Message class #850

Closed

Conversation

Ratery
Copy link
Contributor

@Ratery Ratery commented Jan 25, 2022

Summary

Added thread attribute to the Message class. It returns the thread which was created from the message.
Also then message.create_thread is used message.thread will be automatically updated.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@plun1331
Copy link
Member

I would make the updating of the thread match the various _handle_x methods

@VincentRPS VincentRPS added feature Implements a feature Merge normally priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Jan 26, 2022
@VincentRPS VincentRPS added this to the v2.0 milestone Jan 26, 2022
discord/message.py Outdated Show resolved Hide resolved
discord/message.py Outdated Show resolved Hide resolved
@Lulalaby Lulalaby modified the milestones: v2.0, v2.1 Jan 26, 2022
@Lulalaby
Copy link
Member

Reminder:

⚠️ We currently have a feature freeze

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
@Ratery
Copy link
Contributor Author

Ratery commented Jan 26, 2022

Reminder:

⚠️ We currently have a feature freeze

Yes, I know. But this PR might be merged before 2.1 version release.

Dorukyum
Dorukyum previously approved these changes Jan 26, 2022
@Ratery Ratery requested a review from Lulalaby January 26, 2022 12:41
@Lulalaby Lulalaby marked this pull request as draft January 26, 2022 13:13
@Lulalaby Lulalaby added status: planned Planned in the future and removed status: awaiting review Awaiting review from a maintainer labels Jan 26, 2022
@Ratery Ratery marked this pull request as ready for review February 2, 2022 12:24
@Dorukyum
Copy link
Member

I think we can include this in 2.0 since threads have been added in 2.0 too.

@krittick
Copy link
Contributor

krittick commented Mar 1, 2022

Please resolve conflicts. Thanks!

@Dorukyum
Copy link
Member

Dorukyum commented Mar 4, 2022

Resolved merge conflicts.

@Dorukyum Dorukyum requested a review from krittick March 23, 2022 17:34
@plun1331
Copy link
Member

Should this update a cached message's thread when a thread create/update event is received?

@Lulalaby
Copy link
Member

Should this update a cached message's thread when a thread create/update event is received?

I would say yes

@Lulalaby Lulalaby closed this Jun 11, 2022
@baronkobama baronkobama mentioned this pull request Jun 27, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: low Low Priority status: planned Planned in the future
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

7 participants