Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: option and BridgeOption adjustments #2417

Merged
merged 6 commits into from
Apr 9, 2024
Merged

fix: option and BridgeOption adjustments #2417

merged 6 commits into from
Apr 9, 2024

Conversation

NeloBlivion
Copy link
Member

Summary

  • Support input_type in option decorator to match Option class.
    To preserve backwards compat, type kwarg fallback still exists.
  • Fix parameter_name not being able to inherit a typehinted option type
  • Implement bridge_option decorator
  • Reverts chore(bridge): use BridgeOption instead of Option #2252 until 2.7 to properly allow migration instead of forcing a breaking change with no warning.
    Includes a deprecation warning, but perhaps there's a better way to handle this.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested review from a team as code owners April 9, 2024 05:18
@pullapprove4 pullapprove4 bot requested a review from plun1331 April 9, 2024 05:18
@Lulalaby Lulalaby enabled auto-merge (squash) April 9, 2024 08:08
@Lulalaby Lulalaby merged commit bb61cf7 into Pycord-Development:master Apr 9, 2024
29 checks passed
plun1331 added a commit to SkyKings-Guild/pycord that referenced this pull request Apr 21, 2024
@plun1331 @NeloBlivion
@pre-commit-ci @Lulalaby @dependabot @jordan-day @Dorukyum @JustaSqu1d
j (#4)
51be093 
* feat: add once kwarg to Cog.listener (Pycord-Development#2403)

* add once kwarg to Cog.listener

* clarify

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>

* chore(pre-commit): pre-commit autoupdate (Pycord-Development#2410)

updates:
- [github.com/asottile/pyupgrade: v3.15.1 → v3.15.2](asottile/pyupgrade@v3.15.1...v3.15.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: pass proper state to interaction._guild (Pycord-Development#2411)

* fix: option and BridgeOption adjustments (Pycord-Development#2417)

* chore(pre-commit): pre-commit autoupdate (Pycord-Development#2416)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: implement Guild.search_members (Pycord-Development#2418)

* implement guild member search

* clarification.

* style(pre-commit): auto fixes from pre-commit.com hooks

* cl

* undo iteration

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ci(deps): bump ribtoks/tdg-github-action from 0.4.7.pre.beta to 0.4.10.pre.beta (Pycord-Development#2420)

ci(deps): bump ribtoks/tdg-github-action

Bumps [ribtoks/tdg-github-action](https://github.com/ribtoks/tdg-github-action) from 0.4.7.pre.beta to 0.4.10.pre.beta.
- [Release notes](https://github.com/ribtoks/tdg-github-action/releases)
- [Commits](ribtoks/tdg-github-action@v0.4.7-beta...v0.4.10-beta)

---
updated-dependencies:
- dependency-name: ribtoks/tdg-github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com>

* fix: Added member data to the raw_reaction_remove event (Pycord-Development#2412)

* fix: Added member data to the raw_reaction_remove event

* style(pre-commit): auto fixes from pre-commit.com hooks

* Added changelog.md for adding member data to raw reaction remove

* Update CHANGELOG.md

Signed-off-by: plun1331 <plun1331@gmail.com>

* doc: Updated documentation for the RawReactionActionEvent.member field

---------

Signed-off-by: plun1331 <plun1331@gmail.com>
Co-authored-by: root <root@DESKTOP-U7KGUE3>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com>

* chore(pre-commit): pre-commit autoupdate (Pycord-Development#2422)

updates:
- [github.com/psf/black: 24.3.0 → 24.4.0](psf/black@24.3.0...24.4.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* docs: remove false optional (Pycord-Development#2424)

docs: not optional

* fix: Guild.query_members may accept empty query and limit (Pycord-Development#2419)

Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: plun1331 <plun1331@gmail.com>
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jordan-day <47164307+jordan-day@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-U7KGUE3>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
@BobDotCom BobDotCom mentioned this pull request May 13, 2024
Merged
9 tasks
@tobfd tobfd mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeloBlivion @Lulalaby