Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove module-level deprecation warn #2450

Merged
merged 5 commits into from
May 13, 2024
Merged

fix: remove module-level deprecation warn #2450

merged 5 commits into from
May 13, 2024

Conversation

BobDotCom
Copy link
Member

Summary

Fixes #2449

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@BobDotCom BobDotCom added priority: medium Medium Priority ext.bridge Relating to ext.bridge labels May 13, 2024
@BobDotCom BobDotCom self-assigned this May 13, 2024
@BobDotCom BobDotCom requested review from a team as code owners May 13, 2024 20:14
@BobDotCom BobDotCom linked an issue May 13, 2024 that may be closed by this pull request
DeprecationWarning for BridgeOption raised at module level #2449
Closed
3 tasks
@BobDotCom
Copy link
Member Author

No changelog needed, this just fixes #2417.

@BobDotCom BobDotCom added the status: awaiting review Awaiting review from a maintainer label May 13, 2024
@BobDotCom BobDotCom enabled auto-merge (squash) May 13, 2024 20:17
@BobDotCom
Copy link
Member Author

This was tested here: https://canary.discord.com/channels/881207955029110855/881735314987708456/1239670302506750053

@BobDotCom BobDotCom disabled auto-merge May 13, 2024 20:19
@BobDotCom
Copy link
Member Author

No changelog needed, this just fixes #2417.

Actually a changelog is needed, I added a param to utils.warn_deprecated and utils.deprecated.

@BobDotCom BobDotCom enabled auto-merge (squash) May 13, 2024 20:22
@BobDotCom BobDotCom merged commit ea8a6fe into master May 13, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@BobDotCom BobDotCom

Labels
ext.bridge Relating to ext.bridge priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning for BridgeOption raised at module level
2 participants
@BobDotCom @Lulalaby