Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from reify to property #1270

Closed
wants to merge 1 commit into from
Closed

Change from reify to property #1270

wants to merge 1 commit into from

Conversation

digitalresistor
Copy link
Member

We don't want to cache the factories return.

This solves #1268 (or at least part of it)

We don't want to cache the factories return.
@tseaver
Copy link
Member

tseaver commented Mar 10, 2014

This PR needs a test which fails when using '@reify' but passes with '@Property'. Also, I don't really understand the "we don't want to cache" bit: obviously somebody thought it was supposed to be cached, or we wouldn't be using '@reify'. The PR needs to add a comment (or something) explaining why caching the renderer is not the Right Thing (TM).

@mmerickel
Copy link
Member

As I mentioned in #1268, I think this should be solved in the add_view and ViewDeriver. The @reify is not the primary problem, it's the sharing of a RendererHelper across requests.

@mcdonc
Copy link
Member

mcdonc commented Mar 11, 2014

Please don't merge this. The `@reify`` is purposeful.

@digitalresistor
Copy link
Member Author

Alright, no merging. However the issue as in #1268 remains, should that be fixed as @mmerickel is suggesting with a factory that returns a RenderHelper for each request?

@digitalresistor digitalresistor deleted the bugfix.remove-reify branch March 11, 2014 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants