Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone a new RendererHelper per request #1575

Merged
merged 4 commits into from
Mar 5, 2015
Merged

Conversation

mmerickel
Copy link
Member

fixes #1268

@digitalresistor
Copy link
Member

LGTM.

@mmerickel
Copy link
Member Author

@mcdonc needs to sign-off since he said "don't remove the reify" without providing explanation in #1270

@mcdonc
Copy link
Member

mcdonc commented Mar 4, 2015

LGTM, no real speed concern, and I agree that caching the view renderer between calls is an optimization without much purpose. That said, I think we should add a clone() method to the IRendererInfo interface to make it clear that it is non-optional (even though this is pretty inside baseball).

@mmerickel
Copy link
Member Author

Yeah if we're worried about people using it we could easily pass a lambda/factory through the machinery but since clone was already there with a comment about its use in views, and wasn't actually called anywhere, it seemed like a good thing to use. I will add it to the interface though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching of RendererHelper in view_config()
3 participants