Add some more instances to the GDP constrained layout example #2838
Conversation
| transformer.apply_to(model) | ||
| solver.solve(model) | ||
| print(f"Found objective function value: {model.min_dist_cost()}") | ||
| draw_model(model, title=(key if d == "l1" else f"{key} ({d} distance)")) |
There was a problem hiding this comment.
Minor nit, but why not put which norm in the title all the time?
There was a problem hiding this comment.
Hm. I think I wrote it like this because the l1 norm was the "default" problem specified in the paper and the euclidean distance was a variant invented by me. I can change it though, it should only make things clearer.
|
I've made some changes to resolve these issues, please let me know if there are any others. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
- Coverage 87.48% 87.45% -0.03%
==========================================
Files 771 771
Lines 89598 89650 +52
==========================================
+ Hits 78383 78404 +21
- Misses 11215 11246 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Fixes # .
Summary/Motivation:
(remaking PR to use branch properly)
Adds some additional example instances from Sawaya (2006) to this GDP constrained layout example, and adds some drawings.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: