-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few more GDP examples #2932
A few more GDP examples #2932
Conversation
Now objective values match those generated by scip using the paper's published .nl files. Also add the rest of the instances.
very small example, no need to make 2 PRs)
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
==========================================
- Coverage 88.09% 88.08% -0.01%
==========================================
Files 769 769
Lines 89493 89493
==========================================
- Hits 78836 78832 -4
- Misses 10657 10661 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just a few nits.
This might be a more involved discussion than this PR, but where should we draw the line between a set of examples, tests, and supported models? In particular, for GDP, we have GDPLib https://github.com/SECQUOIA/gdplib, which could host these two examples. What's the motivation for adding them to the main Pyomo repository? |
@bernalde I think this is a great discussion to have outside of this PR. We are inconsistent with how examples are written and tested and also with where they live (both within and outside of the Pyomo repo). I'll open a PEP to start a more comprehensive discussion on this but I don't think this PR needs to wait for it to be resolved. |
I've made the fixes requested, but I can't answer the broader question about where examples should live and how or if they should be tested. These aren't tested for now, since none of their neighbors were. |
@sadavis1 I cancelled the tests to free up GHA resources while we're finalizing things for the release. I'll relaunch them when we're done. |
Fixes # .
Summary/Motivation:
Early in the summer, I worked on a few GDP example problems, the first of which was merged in #2838 . This PR contains the other two GDP example problems from Sawaya (2006) that I implemented. The code solves simple geometric problems and draws pretty pictures.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: