fix: Return original document title when leaving a dashboard (apache#…

…16323) * Return original title on unmount * Name var originalDocumentTitle
QAlexBall · Aug 24, 2021 · 85ea01e · 85ea01e
1 parent 6bca6fe
commit 85ea01e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/superset-frontend/src/dashboard/containers/DashboardPage.tsx b/superset-frontend/src/dashboard/containers/DashboardPage.tsx
@@ -42,6 +42,8 @@ const DashboardContainer = React.lazy(
     ),
 );
 
+const originalDocumentTitle = document.title;
+
 const DashboardPage: FC = () => {
   const dispatch = useDispatch();
   const { addDangerToast } = useToasts();
@@ -71,6 +73,9 @@ const DashboardPage: FC = () => {
     if (dashboard_title) {
       document.title = dashboard_title;
     }
+    return () => {
+      document.title = originalDocumentTitle;
+    };
   }, [dashboard_title]);
 
   useEffect(() => {