-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Return original document title when leaving a dashboard #16323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works nicely! 1 small nit about naming, but not blocking
Codecov Report
@@ Coverage Diff @@
## master #16323 +/- ##
==========================================
- Coverage 76.64% 76.63% -0.01%
==========================================
Files 1000 1000
Lines 53489 53492 +3
Branches 6816 6816
==========================================
Hits 40996 40996
- Misses 12257 12260 +3
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://18.237.109.74:8080. Credentials are |
…issue_16254_tab_title
…issue_16254_tab_title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wonder if we should start using document titles more to make it easier to distinguish between tab contents?
We should definitely look into this |
Ephemeral environment shutdown and build artifacts deleted. |
…16323) * Return original title on unmount * Name var originalDocumentTitle
…16323) * Return original title on unmount * Name var originalDocumentTitle
I know this is a while ago, but was this ever picked up/is planned? I couldn't find something from my search. |
SUMMARY
This PR replaces the document title back to the original one when leaving the dashboard. This is to make sure that the dashboard title does not remain in the browser tab while moving to different pages without reloading.
This is not a definitive solution but a quick fix for the problem reported in #16254. As we move toward eliminating page reloads, the need for a title management implementation arises. In fact, the titles are currently only managed server-side, with the Dashboard page being the only exception.
BEFORE
before_title_change.mp4
AFTER
after_title_change.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION