Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: MacOS TouchBar touch results in weird rotations #354

Open
siberex opened this issue Apr 24, 2020 · 13 comments
Open

BUG: MacOS TouchBar touch results in weird rotations #354

siberex opened this issue Apr 24, 2020 · 13 comments
Labels
macos-only needs-feedback blocked waiting for info/feedback/test-case etc

Comments

@siberex
Copy link

siberex commented Apr 24, 2020

MacOS Catalina 10.15.4
ezQuake 3.2

TouchBar acts like it is joystick with one axis and huge sensitivity.

Slight movement on touchbar results in crazy-fast player rotation in horizontal axis (from left to right or from right to left only, no vertical axis involved).

Wish to know how to disable it
@meag meag mentioned this issue Nov 1, 2020
Closed
@meag
Copy link
Contributor

meag commented Nov 1, 2020

Hi - is this still happening? I'm wondering if it is sent as a touch event rather than mouse input, and we can filter those out (I have nothing to test on here)

meag added a commit to meag/ezquake-source that referenced this issue Nov 2, 2020
@meag
TOUCH EVENTS: filter out by default
72f869c 
Don't get excited, this doesn't appear to be a way
  to disable touchpad - I think it only applies to
  touchscreens etc, am hoping it helps with QW-Group#354
Nothing to test with here
@meag
Copy link
Contributor

meag commented Nov 3, 2020

If someone could try latest from master and see if /in_ignore_touch_events makes any difference, that would be appreciated.

@meag meag changed the title MacOS TouchBar touch results in weird rotations BUG: MacOS TouchBar touch results in weird rotations Nov 7, 2020
@meag meag added the needs-feedback blocked waiting for info/feedback/test-case etc label Nov 7, 2020
@maniacQW
Copy link

I've tried it for you. /in_ignore_touch_events does not affect the reported behaviour.

@meag
Copy link
Contributor

meag commented Jan 19, 2021

Thanks - was a long shot anyway.

I'll try something else in another commit soon and we'll see if that helps, hopefully there's some way we can identify the touchbar.

meag added a commit to meag/ezquake-source that referenced this issue Jan 24, 2021
@meag
INPUT: Block touch motion events, and debug output
5245371 
See QW-Group#354
meag added a commit that referenced this issue Jan 24, 2021
@meag
INPUT: Block touch motion events, and debug output
1b4fcb0 
See #354
@meag
Copy link
Contributor

meag commented Jan 24, 2021

Hi @maniacQW can you try again when you get a chance please? no rush.

@maniacQW
Copy link

maniacQW commented Feb 2, 2021

sorry @meag for being this late. I've tried it with today's nightly, same issue occurs.

@meag
Copy link
Contributor

meag commented Feb 8, 2021

thanks @maniacQW - can you try setting /developer 2 and then using the touchbar vs using the mouse/trackpad etc? It should list which deviceId the data is coming from, I'm hoping that we get different values for each...

@maniacQW
Copy link

maniacQW commented Feb 9, 2021

I've set developer 2 from console, but it prints nothing to the console when pressing a key on keyboard or using the touchbar. Only on moving the mouse, it prints "motion event", etc.

@meag
Copy link
Contributor

meag commented Feb 22, 2021

Sorry, lost track of this... that's good actually, narrows it down a bit. I'll update again tonight with more debugging, and hopefully we'll catch how the touchbar events are arriving.

meag added a commit to meag/ezquake-source that referenced this issue Feb 22, 2021
@meag
MACOS: More event debugging for TouchBar
2dce1b6 
For QW-Group#354, developer 2 to activate
@meag
Copy link
Contributor

meag commented Feb 23, 2021

Hi @maniacQW - I've added mouse buttons & keyboard input to MacOS build when developer 2 is set... can you try again and hopefully when you use the touchbar we'll see what events it is receiving.

Thanks,

@meag meag added the macos-only label Mar 7, 2021
meag added a commit to meag/ezquake-source that referenced this issue Aug 4, 2021
@meag
OSX: Disable synthetic touch=>mouse conversion
75313ef 
No idea if this will help with QW-Group#354, need
  someone with touchbar to test
(or someone to explain to me how to use touchbar
  simulator in xcode with ezQuake)
@meag
Copy link
Contributor

meag commented Aug 4, 2021

Hi

Can someone with a touchbar try again now please? And with /developer 2 set, see if any messages appear in the console when using touchbar.

Thanks,
meag

meag added a commit to meag/ezquake-source that referenced this issue Nov 14, 2021
@meag
VERSION: alpha9
2858ada 
### Changes from alpha8=>alpha9 (July 13th => November 14th, 2021)

- Fixed/worked around some classic renderer bugs on version x.y.13399 AMD drivers (QW-Group#416)
- Fixed bug causing off-by-one error when drawing rectangle outlines (3.5 bug, reported by Matrix, QW-Group#536)
- Fixed `/in_raw 0` behaviour on MacOS (QW-Group#489)
- Fixed `/r_drawflat 1`, `/r_drawflat_mode 0` affecting ammo boxes etc in classic renderer
- Fixed match logging not working when using competitive rulesets
- Fixed incomplete rendering when gibbed or dead in shallow water (reported by Matrix, QW-Group#568)
- Fixed tab key not switching tabs on serverinfo popup (reported by Hangtime, QW-Group#555)
- Fixed `/demo_jump_mark` not working if `/demo_jump_rewind` not set
- Fixed coping with 1x1 ibar.png (reported by Matrix, QW-Group#571)
- Fixed powerupshells when using `/r_viewmodelsize` (reported by timbergeron, QW-Group#573)
- Fixed crouch adjustment staying disabled after teleport/respawn when `/cl_nopred` enabled (reported by Matrix, QW-Group#572)
- Added `/gl_smoothmodels` back in (modern renderer only), (requested by Repast via [quakeworld.nu](https://www.quakeworld.nu/forum/topic/7508/why-is-the-command-glsmoothmodels-r))
- Added `/demo_jump_skip_messages` to determine if messages should be printed to console during demo jump
- Added `/demo_jump_end` to jump to next intermission point or end of demo (requested by Hangtime, QW-Group#564)
- Added `/sb_info_filter` to allow filtering of servers in server-browser based on serverinfo (requested by Matrix, QW-Group#537)
- On startup (after `autoexec.cfg` executed), a `vid_restart`/`s_restart` will be issued if any latched variables were changed (reported by Dusty, QW-Group#458)
- Multiview will be disabled when watching a solo demo and no powerup cams are active (requested by mmavova, QW-Group#126)
- MacOS: sets SDL flag to stop touch events being translated into mouse events (might help with QW-Group#354)
- `/status` command will be ignored if an alias with the same name is found, use `/sv_status` instead (fixes QW-Group#532)
- qw:// urls in command line will be opened even if not preceded by `+qwurl` (thanks to ciscon)
- Linux: register_qwurl_protocol will register protocol with xdg (thanks to ciscon)
- Added `/v_dlightcolor` to control if being inside flashblend light affects palette by color of light
- Added `/v_dlightcshiftpercent` to control strength of palette shift effect when inside flashblend light
- Changed `/v_dlightcshift` to be enum of when being inside flashblend light affects palette (requested by HangTime, QW-Group#542)
- Added `/vid_framebuffer_multisample` to control multi-sampling level of the framebuffer (reported by Matrix, QW-Group#367)
- Translucent models are first drawn with a z-pass, to stop overdraw affecting level of translucency
- Fixed explosion effects on md3 viewmodels (additive blending was being lost)
- Removed server-side weapon switching 'support' in client
- Removed debugging messages when using `+fire_ar`
- Commands that search by regular expression (`/cvarlist_re` etc) are now case-insensitive (reported by HangTime, QW-Group#599)
- Added `/fs_savegame_home` to control if games are saved to home directory (default) or game directory (reported by githubtefo, QW-Group#586)
- Fixed `/gl_no24bit` not taking effect after `/vid_restart` (reported by hemostx, QW-Group#601)
- Fixed `/gl_no24bit` not disabling loading external textures (3.5 bug, kind of reported by hemostx, QW-Group#601)
- Fixed bug causing `/gl_scaleskytextures` to not affect external textures (reported & fixed by hemostx, QW-Group#606)
@meag
Copy link
Contributor

meag commented Jan 27, 2022

It looks like Apple have binned the Touchbar? I can't even find a keyboard to buy to test it manually (anyone?)

@qqshka
Copy link
Collaborator

qqshka commented Jan 27, 2022

what exactly need to be done? Just set /developer 2 and use touchbar for a little bit and check for messages in console?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
macos-only needs-feedback blocked waiting for info/feedback/test-case etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@qqshka @siberex @meag @maniacQW