Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: vid_renderer doesn't hold value when loaded from config (nQuake) #458

Closed
meag opened this issue Dec 13, 2020 · 9 comments
Closed

BUG: vid_renderer doesn't hold value when loaded from config (nQuake) #458

meag opened this issue Dec 13, 2020 · 9 comments
Labels
blocks-release Needs to be fixed before next release is complete needs-feedback blocked waiting for info/feedback/test-case etc

Comments

@meag
Copy link
Contributor

meag commented Dec 13, 2020

Please search for existing issues and check for potential duplicates before filing yours.

ezQuake version:
3.6-alphaX

OS/device including version:
using the switchable renderer version, not sure which OS

Describe the bug
[03:13]Dusty:any reason why QW wouldn't remember vid_renderer 1 after restarting? very strange
[03:13]dirtbox:I've heard of other people complaining about that @dusty
[03:13]dirtbox:Put +vid_renderer 1 on your cmdline
[03:13]dirtbox:it still requires a vid_restart though
@meag
Copy link
Contributor Author

meag commented Dec 13, 2020

Cannot reproduce, neither can eb
Wonder if this is nquake issue where the config file is loaded from another config file and so loaded later than normal

@liback
Copy link
Contributor

liback commented Dec 13, 2020

If it's happening in nQuake installs from before Oct 2017 then it might be the first problem in this list:
https://www.quakeworld.nu/news/1029/nquake-config-updates

@liback
Copy link
Contributor

liback commented Dec 14, 2020 •
edited
Loading

Seems to be an nQuake related issue, however the behavior works in ezQuake 3.2.2 but not in 3.6 (using vid_fullscreen as an example that requires a vid_restart and exists in both versions)

To reproduce:

  • Download nQuake
  • Drop ezQuake 3.6 in nQuake folder
  • Start ezQuake 3.6
  • vid_fullscreen 0
  • vid_restart
  • cfg_save
  • Close ezQuake
  • Start ezQuake 3.6
  • vid_fullscreen is now only latched

@meag
Copy link
Contributor Author

meag commented Dec 14, 2020

Thanks @liback. Thought it looked like a problem with nquake using default.cfg as that changed fairly recently, but that doesn't seem to be the case (502c76d)

Very frustrating couple of hours later...

Executing: samelevel 8393473 // ffa
Executing: 
Executing: 
Executing: con_bindphysical 1
Executing: exec configs/config.cfg		// From ezquake/configs/
execing C:/nquake/ezquake/configs/config.cfg
Cbuf_InsertText: overflow
Executing: con_bindphysical 1
Executing: 
Executing: con_bindphysical 1

Will need to look into why that overflow is happening...

@meag
Copy link
Contributor Author

meag commented Dec 16, 2020

Not sure this helps, but I get the same behaviour in ezQuake 3.2, if config.cfg exists in the home directory. The homedir is always searched first during startup, so loaded before nQuake's autoexec.cfg is executed

meag added a commit to meag/ezquake-source that referenced this issue Dec 16, 2020
@meag
CMD: Execute & flush default.cfg before config
93d1b35 
Found when looking into QW-Group#458
nQuake's autoexec will execute it again
@meag meag changed the title BUG: vid_renderer doesn't hold value when loaded from config BUG: vid_renderer doesn't hold value when loaded from config (nQuake) Dec 20, 2020
meag added a commit that referenced this issue Jan 24, 2021
@meag
CMD: Execute & flush default.cfg before config
a8b1f41 
Found when looking into #458
nQuake's autoexec will execute it again
@meag meag added the blocks-release Needs to be fixed before next release is complete label Feb 20, 2021
meag added a commit to meag/ezquake-source that referenced this issue Feb 20, 2021
@meag
CONFIGS: Ignore nquake's default.cfg
6369224 
This is executed by nquake's autoexec.cfg
Might help with QW-Group#458
@meag
Copy link
Contributor Author

meag commented Feb 21, 2021

Is this still an issue? I tried today and it was okay, but that was saving to homedir etc, not sure if my settings match nquake defaults

@meag meag added the needs-feedback blocked waiting for info/feedback/test-case etc label Feb 22, 2021
@meag
Copy link
Contributor Author

meag commented Feb 27, 2021

This still seems to be a problem if homedir config doesn't have the vid_renderer value set

meag added a commit to meag/ezquake-source that referenced this issue Jul 14, 2021
@meag
STARTUP: Do vid/sound restart if autoexec triggers
76bdf11 
For QW-Group#458

Bit kludgy, but essentially check if any latched
  cvars set and then vid_restart/s_restart as needed

Native configs picked up normally through homedir
  and loaded before initialisation takes place
  (registered cvars copy values over)
nQuake stores configs in local directory by default,
  but then they won't be picked up normally so nQuake
  includes an autoexec.cfg hack which executes config.cfg
  from local directory, but initialisation has already
  taken place

Moving autoexec.cfg firing prior to startup also fixes
  it and seems cleaner, but as some people may have
  autoexec.cfg that expect systems to be initialised
  so no doubt that would bring its own problems...

Can we have non-executable configs please? :(
@meag
Copy link
Contributor Author

meag commented Jul 14, 2021

Hoping we can mark this fixed(ish) now?

@meag
Copy link
Contributor Author

meag commented Jul 15, 2021

Closing, please re-open if still an issue.

@meag meag closed this as completed Jul 15, 2021
meag added a commit to meag/ezquake-source that referenced this issue Nov 14, 2021
@meag
VERSION: alpha9
2858ada 
### Changes from alpha8=>alpha9 (July 13th => November 14th, 2021)

- Fixed/worked around some classic renderer bugs on version x.y.13399 AMD drivers (QW-Group#416)
- Fixed bug causing off-by-one error when drawing rectangle outlines (3.5 bug, reported by Matrix, QW-Group#536)
- Fixed `/in_raw 0` behaviour on MacOS (QW-Group#489)
- Fixed `/r_drawflat 1`, `/r_drawflat_mode 0` affecting ammo boxes etc in classic renderer
- Fixed match logging not working when using competitive rulesets
- Fixed incomplete rendering when gibbed or dead in shallow water (reported by Matrix, QW-Group#568)
- Fixed tab key not switching tabs on serverinfo popup (reported by Hangtime, QW-Group#555)
- Fixed `/demo_jump_mark` not working if `/demo_jump_rewind` not set
- Fixed coping with 1x1 ibar.png (reported by Matrix, QW-Group#571)
- Fixed powerupshells when using `/r_viewmodelsize` (reported by timbergeron, QW-Group#573)
- Fixed crouch adjustment staying disabled after teleport/respawn when `/cl_nopred` enabled (reported by Matrix, QW-Group#572)
- Added `/gl_smoothmodels` back in (modern renderer only), (requested by Repast via [quakeworld.nu](https://www.quakeworld.nu/forum/topic/7508/why-is-the-command-glsmoothmodels-r))
- Added `/demo_jump_skip_messages` to determine if messages should be printed to console during demo jump
- Added `/demo_jump_end` to jump to next intermission point or end of demo (requested by Hangtime, QW-Group#564)
- Added `/sb_info_filter` to allow filtering of servers in server-browser based on serverinfo (requested by Matrix, QW-Group#537)
- On startup (after `autoexec.cfg` executed), a `vid_restart`/`s_restart` will be issued if any latched variables were changed (reported by Dusty, QW-Group#458)
- Multiview will be disabled when watching a solo demo and no powerup cams are active (requested by mmavova, QW-Group#126)
- MacOS: sets SDL flag to stop touch events being translated into mouse events (might help with QW-Group#354)
- `/status` command will be ignored if an alias with the same name is found, use `/sv_status` instead (fixes QW-Group#532)
- qw:// urls in command line will be opened even if not preceded by `+qwurl` (thanks to ciscon)
- Linux: register_qwurl_protocol will register protocol with xdg (thanks to ciscon)
- Added `/v_dlightcolor` to control if being inside flashblend light affects palette by color of light
- Added `/v_dlightcshiftpercent` to control strength of palette shift effect when inside flashblend light
- Changed `/v_dlightcshift` to be enum of when being inside flashblend light affects palette (requested by HangTime, QW-Group#542)
- Added `/vid_framebuffer_multisample` to control multi-sampling level of the framebuffer (reported by Matrix, QW-Group#367)
- Translucent models are first drawn with a z-pass, to stop overdraw affecting level of translucency
- Fixed explosion effects on md3 viewmodels (additive blending was being lost)
- Removed server-side weapon switching 'support' in client
- Removed debugging messages when using `+fire_ar`
- Commands that search by regular expression (`/cvarlist_re` etc) are now case-insensitive (reported by HangTime, QW-Group#599)
- Added `/fs_savegame_home` to control if games are saved to home directory (default) or game directory (reported by githubtefo, QW-Group#586)
- Fixed `/gl_no24bit` not taking effect after `/vid_restart` (reported by hemostx, QW-Group#601)
- Fixed `/gl_no24bit` not disabling loading external textures (3.5 bug, kind of reported by hemostx, QW-Group#601)
- Fixed bug causing `/gl_scaleskytextures` to not affect external textures (reported & fixed by hemostx, QW-Group#606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocks-release Needs to be fixed before next release is complete needs-feedback blocked waiting for info/feedback/test-case etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meag @liback