Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/events): remove threads from handler #583

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix(server/events): remove threads from handler #583

merged 3 commits into from
Sep 25, 2024

Conversation

solareon
Copy link
Contributor

Description

Previous fix didn't scale properly to higher player counts. This sets the metadata prior to the statebag preventing infinite recursion

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@solareon solareon requested a review from Manason September 25, 2024 16:18
@solareon
Copy link
Contributor Author

Fixes #578

D4isDAVID
D4isDAVID approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@D4isDAVID D4isDAVID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was fine when testing.

@rust1co
Copy link

rust1co commented Sep 25, 2024

Tested and Ok, Thanks Solareon

@Manason Manason merged commit 07528de into main Sep 25, 2024
4 checks passed
@Manason Manason deleted the fix-statebag-threads branch September 25, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D4isDAVID D4isDAVID D4isDAVID approved these changes

@Manason Manason Manason approved these changes

@mafewtm mafewtm Awaiting requested review from mafewtm

@KostaZx KostaZx Awaiting requested review from KostaZx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@solareon @rust1co @Manason @D4isDAVID