Add support for noise model and level 1 data to local sampler #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't make sense to merge this unless Qiskit/qiskit#13357 is also on a path to being merged. If that is the case though, it should be safe to merge this because it should not change behavior if the added options are not used and also it checks that the options are defined before using them, so it doesn't need to wait for Qiskit/qiskit#13357 to be released first. |
wshanks
force-pushed
the
local-primitive-options
branch
from
f30dea8 to
eb99965
Compare
wshanks
force-pushed
the
local-primitive-options
branch
from
eb99965 to
603808f
Compare
This change passes through the `simulator.noise_model` option to the `BackendSamplerV2` as a `noise_model` option under `run_options` if the primitive supports the `run_options` option (support was added in Qiskit 1.3). Additionally, this change translates the `execution.meas_type` option into `meas_level` and `meas_return` options under `run_options` for the `BackendSamplerV2` if it supports `run_options`. This change allows support for level 1 data in local testing mode, where otherwise the default is only to return classified data.
wshanks
force-pushed
the
local-primitive-options
branch
from
603808f to
0ed915f
Compare
kt474
added
the
Changelog: New Feature
kt474
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change passes through the
simulator.noise_modeloption to theBackendSamplerV2as anoise_modeloption ofrun_optionsif the primitive supports therun_optionsoption (support was added in Qiskit 1.3).Additionally, this change translates the
execution.meas_typeoption intomeas_levelandmeas_returnoptions ofrun_optionsif theBackendSamplerV2supportsrun_options. This change allows support for level 1 data in local testing mode, where otherwise the default is only to return classified data.