-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workarounds for passing run options to sampler #1498
Conversation
This runtime patching code was added along with the initial support for sampler execution because the path through `qiskit_ibm_runtime.SamplerV2` through to `BackendSamplerV2` did not carry through options for level 1 measurements or noise models. This path is used in the tests (while execution on physical backends with `SamplerV2` does not use this path). Now with Qiskit 1.3 and qiskit-ibm-runtime 0.34, this patching is no longer needed. Remaining warnings filtering was moved to the calibrations tutorial where it was needed.
944289d
to
1a1d17d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain some more, what was the situation before the recent versions of qiskit and qiskit-ibm-runtime, and what has changed. How did physical backends cope with measurement level 1?
Co-authored-by: Yael Ben-Haim <yaelbh@il.ibm.com>
In #1470, the default behavior of To keep our tests working for #1470, I added the code removed in this PR which monkey patches the code related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved (I can't click the Approve button for some reason)
This runtime patching code was added along with the initial support for sampler execution because the path through `qiskit_ibm_runtime.SamplerV2` through to `BackendSamplerV2` did not carry through options for level 1 measurements or noise models. This path is used in the tests (while execution on physical backends with `SamplerV2` does not use this path). Now with Qiskit 1.3 and qiskit-ibm-runtime 0.34, this patching is no longer needed. Remaining warnings filtering was moved to the calibrations tutorial where it was needed. --------- Co-authored-by: Yael Ben-Haim <yaelbh@il.ibm.com> (cherry picked from commit 9bf2848)
#1500) This runtime patching code was added along with the initial support for sampler execution because the path through `qiskit_ibm_runtime.SamplerV2` through to `BackendSamplerV2` did not carry through options for level 1 measurements or noise models. This path is used in the tests (while execution on physical backends with `SamplerV2` does not use this path). Now with Qiskit 1.3 and qiskit-ibm-runtime 0.34, this patching is no longer needed. Remaining warnings filtering was moved to the calibrations tutorial where it was needed.<hr>This is an automatic backport of pull request #1498 done by [Mergify](https://mergify.com). Co-authored-by: Will Shanks <willshanks@us.ibm.com>
This runtime patching code was added along with the initial support for sampler execution because the path through
qiskit_ibm_runtime.SamplerV2
through toBackendSamplerV2
did not carry through options for level 1 measurements or noise models. This path is used in the tests (while execution on physical backends withSamplerV2
does not use this path). Now with Qiskit 1.3 and qiskit-ibm-runtime 0.34, this patching is no longer needed. Remaining warnings filtering was moved to the calibrations tutorial where it was needed.