Skip to content

Commit

Permalink
Remove legacy-editable option from setuptools builds (#13059)
Browse files Browse the repository at this point in the history
We needed this back when `setuptools` first introduced the new editable
installations, but at this point it should work more correctly without
it; our non-CI configurations haven't included it for some time.
  • Loading branch information
jakelishman authored Aug 30, 2024
1 parent edb249e commit 05a9b55
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 11 deletions.
4 changes: 0 additions & 4 deletions .azure/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ jobs:
# Build and install both qiskit and qiskit-terra so that any optionals
# depending on `qiskit` will resolve correctly.
displayName: "Install Terra directly"
env:
SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
- ${{ if eq(parameters.installOptionals, true) }}:
- bash: |
Expand Down Expand Up @@ -178,8 +176,6 @@ jobs:
sudo apt-get install -y graphviz pandoc
image_tests/bin/pip check
displayName: 'Install dependencies'
env:
SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
- bash: |
echo "##vso[task.setvariable variable=HAVE_VISUAL_TESTS_RUN;]true"
Expand Down
2 changes: 0 additions & 2 deletions .azure/test-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ jobs:
# depending on `qiskit` will resolve correctly.
pip check
displayName: 'Install dependencies'
env:
SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
- ${{ if eq(parameters.installOptionals, true) }}:
- bash: |
Expand Down
2 changes: 0 additions & 2 deletions .azure/test-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ jobs:
# depending on `qiskit` will resolve correctly.
pip check
displayName: 'Install dependencies'
env:
SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
- ${{ if eq(parameters.installOptionals, true) }}:
- bash: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:
CARGO_INCREMENTAL: 0
RUSTFLAGS: "-Cinstrument-coverage"
LLVM_PROFILE_FILE: "qiskit-%p-%m.profraw"
SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"

- name: Generate unittest coverage report
run: |
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/slow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ jobs:
python -m pip install -U -r requirements-dev.txt -c constraints.txt
python -m pip install -c constraints.txt -e .
python -m pip install "qiskit-aer" "z3-solver" "cplex" -c constraints.txt
env:
SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
- name: Run all tests including slow
run: stestr run
env:
Expand Down

0 comments on commit 05a9b55

Please sign in to comment.