Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard 1q Pauli equivalences to standard library #10300

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

jakelishman
Copy link
Member

Summary

This makes transpile a little more reliable in cases where people are trying to use it to convert to a constrained basis. We can't necessarily recognise all possible transformations into an incomplete basis, but simple Pauli relations are things people may well expect.

Details and comments

Fix #10293.

This makes `transpile` a little more reliable in cases where people are
trying to use it to convert to a constrained basis.  We can't
necessarily recognise _all_ possible transformations into an incomplete
basis, but simple Pauli relations are things people may well expect.
@jakelishman jakelishman added Changelog: New Feature Include in the "Added" section of the changelog mod: transpiler Issues and PRs related to Transpiler labels Jun 16, 2023
@jakelishman jakelishman added this to the 0.25.0 milestone Jun 16, 2023
@jakelishman jakelishman requested a review from a team as a code owner June 16, 2023 11:35
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

mtreinish
mtreinish previously approved these changes Jun 16, 2023
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is a straightforward addition to the standard equivalence library that makes sense to have.

@jakelishman
Copy link
Member Author

Helps if I remember to use the opt_level test parametrisation that I set up, haha.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5289644275

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.001%) to 85.94%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 91.14%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
crates/qasm2/src/parse.rs 12 96.65%
Totals Coverage Status
Change from base Build 5284896987: 0.001%
Covered Lines: 71348
Relevant Lines: 83021

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Jun 16, 2023
Merged via the queue into Qiskit:main with commit 45a1d98 Jun 16, 2023
@jakelishman jakelishman deleted the add-pauli-equivalences branch June 16, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: transpiler Issues and PRs related to Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basis gate decomposition success depends on knowing internal implimentation details
4 participants