Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated algorithm_globals and validation utils. #11252

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Nov 15, 2023

Summary

This PR closes #10991 with the removal of the last algorithm utils: validation and algorithm_globals.

Details and comments

This is PR # 4 of the "Opflow & Algorithms deprecation series", and intended to be the series finale. It will be on hold until #11111 is merged.

@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Nov 24, 2023
@ElePT ElePT force-pushed the remove-algorithm-utils branch from 5f8208f to a02f510 Compare November 24, 2023 12:09
@ElePT ElePT added this to the 1.0.0 milestone Nov 24, 2023
@ElePT ElePT marked this pull request as ready for review November 24, 2023 12:10
@ElePT ElePT requested review from woodsp-ibm and a team as code owners November 24, 2023 12:10
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6980552329

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 87.07%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.67%
crates/qasm2/src/parse.rs 12 97.13%
Totals Coverage Status
Change from base Build 6980540179: 0.06%
Covered Lines: 60803
Relevant Lines: 69832

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Nov 24, 2023
Merged via the queue into Qiskit:main with commit ba5a1a6 Nov 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove opflow and algorithms modules post-0.45 rc
6 participants