-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated opflow
module, QuantumInstance
and related utils
#11111
Conversation
One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this will break some cross-references for the migration guides. That's fine because the migration guides are ported already to https://docs.quantum-computing.ibm.com/api/migration-guides and we're planning to switch the qisk.it
short links this week to them. The IBM docs will update their links to use the 0.44
version of the API docs
FYI: A PR is updating backend_utils for Aer 0.13 compatibility and is designated to be backported #11172 so I imagine we will want that to merge before the module gets deleted by this PR |
Pull Request Test Coverage Report for Build 6946461063Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing all this, Elena. It looks like we're on the verge of being ready to go, with overzealous type hints in Aer 0.13 being the only thing that prevents Neko from passing and this from merging.
With Qiskit/qiskit-aer#1996 now merged, we're just waiting on the 0.13.1 patch release of Aer, which at the time of writing, looks just about ready to go: Qiskit/qiskit-aer#1983.
SPARSE_PAULI_OP_LIST_ELEM | ||
------------------------- | ||
|
||
This represents an instance of :class:`.PauliSumOp`. | ||
This represents an instance of :class:`.SparsePauliOp`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
Co-authored-by: Jake Lishman <jake@binhbar.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this! I think this PR is completely ready to merge from our side, we're just waiting for Aer 0.13.1 so Neko can pass.
From above, since its still not happened
|
Approved and added to the merge queue! |
…into remove-opflow
On hold until Aer 0.13.1 is released. |
With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 along with the removal of the BIPMapping transpiler pass in Qiskit#10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
With the removal of algorithms and opflow in #11324, #11111, and #11086 along with the removal of the BIPMapping transpiler pass in #10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
Summary
This PR partially addresses #10991 by removing
qiskit.opflow
,qiskit.utils.quantum_instance.py
, and related utils:qiskit/utils/backend_utils.py
qiskit/utils/measurement_error_mitigation.py
qiskit/utils/mitigation/*
qiskit/utils/run_circuits.py
As well as removing their unit tests, updating the related sphinx references, and removing the API reference entry.
Details and comments
This is PR # 3 of the "Opflow & Algorithms deprecation series", it is on hold until #11086 is merged.