-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated BIPMapping pass #10526
Conversation
One or more of the the following people are requested to review this:
|
releasenotes/notes/remove-deprecated-bip-mapper-e1206c8f905502dd.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/remove-deprecated-bip-mapper-e1206c8f905502dd.yaml
Outdated
Show resolved
Hide resolved
This commit removes the deprecated BIPMapping pass. It was deprecated in qiskit-terra 0.24.0 and the minimum deprecation period has elapsed for the Qiskit 0.45.0 release. This pass has been moved to an external plugin that can be installed separately and integrated into the transpiler more cleanly than a single pass and also separates the optional dependency on the proprietary CPLEX into a separate package.
Co-authored-by: Kevin Hartman <kevin@hart.mn>
f6a394c
to
0aaefd7
Compare
There were still two locations where the BIPMapping pass was being used. First the dedicated unit tests, and then also import redirects for the docs and easier access. This commit removes these locations so nothing left is using the BIPMapping pass.
0aaefd7
to
88aef1e
Compare
Pull Request Test Coverage Report for Build 6160673765
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the docs and install hints around HAS_CPLEX
and HAS_DOCPLEX
to comment that they're no longer used by Qiskit, and update their install
hints to remove the reference to the (already) non-existent extra bip-mapper
?
I updated the docs in: 83a0d28 |
There's also the |
I updated them in: 2a72879 it makes sense to do it here even if it was pre-existing. I felt a bit odd about the cplex one though, because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the CPLEX situation was always a bit of a problem, which is in part why we've walked the path that's led us to this PR overall haha.
The actual install
command in the checkers isn't really going to matter because nobody will see it any more, but at least now it's not obviously incorrect.
With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086 along with the removal of the BIPMapping transpiler pass in Qiskit#10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
With the removal of algorithms and opflow in #11324, #11111, and #11086 along with the removal of the BIPMapping transpiler pass in #10526 several optional test dependencies are no longer used in the code base. This commit removes them from requirements-optional.txt as several have compatibility issues with Python 3.12 and are causing failures in the nightly builds. Since they're no longer used we shouldn't bother installing them anymore.
Summary
This commit removes the deprecated BIPMapping pass. It was deprecated in qiskit-terra 0.24.0 and the minimum deprecation period has elapsed for the Qiskit 0.45.0 release. This pass has been moved to an external plugin that can be installed separately and integrated into the transpiler more cleanly than a single pass and also separates the optional dependency on the proprietary CPLEX into a separate package.
Details and comments