Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused optional requirements #11364

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

mtreinish
Copy link
Member

Summary

With the removal of algorithms and opflow in #11324, #11111, and #11086
along with the removal of the BIPMapping transpiler pass in #10526
several optional test dependencies are no longer used in the code base.
This commit removes them from requirements-optional.txt as several have
compatibility issues with Python 3.12 and are causing failures in the
nightly builds. Since they're no longer used we shouldn't bother
installing them anymore.

Details and comments

With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086
along with the removal of the BIPMapping transpiler pass in Qiskit#10526
several optional test dependencies are no longer used in the code base.
This commit removes them from requirements-optional.txt as several have
compatibility issues with Python 3.12 and are causing failures in the
nightly builds. Since they're no longer used we shouldn't bother
installing them anymore.
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Dec 3, 2023
@mtreinish mtreinish requested a review from a team as a code owner December 3, 2023 15:12
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7077694291

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 87.469%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 92.42%
Totals Coverage Status
Change from base Build 7070692716: 0.03%
Covered Lines: 59940
Relevant Lines: 68527

💛 - Coveralls

@jakelishman jakelishman enabled auto-merge December 3, 2023 16:13
@jakelishman jakelishman added this pull request to the merge queue Dec 3, 2023
Merged via the queue into Qiskit:main with commit 6137248 Dec 3, 2023
13 checks passed
@mtreinish mtreinish deleted the remove-optionals-unused branch December 4, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants