Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue 9453 by removing "_v2" from name in BackendV2 class #9465

Merged
merged 4 commits into from
Apr 11, 2023
Merged

fixed issue 9453 by removing "_v2" from name in BackendV2 class #9465

merged 4 commits into from
Apr 11, 2023

Conversation

shivalee12
Copy link
Contributor

Summary

fixes issue #9453

Details and comments

as suggested by @pedrorrivero to keep the consistency with naming convention of backend names, removed " _v2" from all backend names in fake BackendV2 classes.

@shivalee12 shivalee12 requested review from a team and jyu00 as code owners January 26, 2023 08:32
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jan 26, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@HuangJunye HuangJunye self-assigned this Jan 26, 2023
HuangJunye
HuangJunye reviewed Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@HuangJunye HuangJunye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your first time contribution! This is looking good. Can you please add a release note to document the change? You can find instructions for how to write release notes here. If you need help, please don't hesitate to reach out to me.

@coveralls
Copy link

coveralls commented Feb 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4672097748

  • 39 of 39 (100.0%) changed or added relevant lines in 39 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 85.408%
Files with Coverage Reduction New Missed Lines %
qiskit/circuit/tools/pi_check.py 1 91.23%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 95.14%
qiskit/pulse/library/waveform.py 3 91.67%
Totals Coverage Status
Change from base Build 4671582287: -0.02%
Covered Lines: 67649
Relevant Lines: 79207
💛 - Coveralls

@kdk kdk added the Changelog: API Change Include in the "Changed" section of the changelog label Feb 7, 2023
@kdk kdk added this to the 0.24.0 milestone Feb 7, 2023
kdk
kdk reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Can you add a short release note highlighting that the names for FakeBackendV2 instances have changed? (https://github.com/Qiskit/qiskit-terra/blob/main/CONTRIBUTING.md#release-notes has info on how to add release notes).

@HuangJunye HuangJunye linked an issue Feb 21, 2023 that may be closed by this pull request
Strip _v2 from name in fake BackendV2 classes #9453
Closed
@mtreinish mtreinish self-assigned this Apr 11, 2023
mtreinish
mtreinish approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just added the release note to unblock this

@mtreinish mtreinish added this pull request to the merge queue Apr 11, 2023
Merged via the queue into Qiskit:main with commit 3cf4d77 Apr 11, 2023
giacomoRanieri pushed a commit to giacomoRanieri/qiskit-terra that referenced this pull request Apr 16, 2023
@shivalee12 @HuangJunye
@mtreinish @giacomoRanieri
fixed issue 9453 by removing "_v2" from name in BackendV2 class (Qisk…
c37d253 
…it#9465)

* fixed issue 9453 by stripping _v2 from name in BackendV2 class

* Add release note

---------

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@shivalee12 shivalee12 deleted the fixissue9453branch branch May 18, 2023 05:43
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
@shivalee12 @HuangJunye
@mtreinish @king-p3nguin
fixed issue 9453 by removing "_v2" from name in BackendV2 class (Qisk…
25e7438 
…it#9465)

* fixed issue 9453 by stripping _v2 from name in BackendV2 class

* Add release note

---------

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@shivalee12 shivalee12 restored the fixissue9453branch branch June 24, 2023 18:18
ElePT pushed a commit to ElePT/qiskit-ibm-provider that referenced this pull request Oct 4, 2023
@shivalee12 @HuangJunye @mtreinish
fixed issue 9453 by removing "_v2" from name in BackendV2 class (Qisk…
864caa3 
…it/qiskit#9465)

* fixed issue 9453 by stripping _v2 from name in BackendV2 class

* Add release note

---------

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
ElePT pushed a commit to ElePT/qiskit-ibm-runtime that referenced this pull request Oct 10, 2023
@shivalee12 @HuangJunye @mtreinish
fixed issue 9453 by removing "_v2" from name in BackendV2 class (Qisk…
9bef73c 
…it/qiskit#9465)

* fixed issue 9453 by stripping _v2 from name in BackendV2 class

* Add release note

---------

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Oct 12, 2023
@shivalee12 @HuangJunye @mtreinish
fixed issue 9453 by removing "_v2" from name in BackendV2 class (Qisk…
0cc0819 
…it#9465)

* fixed issue 9453 by stripping _v2 from name in BackendV2 class

* Add release note

---------

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
ElePT pushed a commit to ElePT/qiskit-ibm-runtime that referenced this pull request Dec 8, 2023
@shivalee12 @HuangJunye @mtreinish
fixed issue 9453 by removing "_v2" from name in BackendV2 class (Qisk…
1187b3b 
…it/qiskit#9465)

* fixed issue 9453 by stripping _v2 from name in BackendV2 class

* Add release note

---------

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuangJunye HuangJunye HuangJunye left review comments

@kdk kdk kdk left review comments

@mtreinish mtreinish mtreinish approved these changes

@jyu00 jyu00 Awaiting requested review from jyu00 jyu00 is a code owner

Assignees

@mtreinish mtreinish

@HuangJunye HuangJunye

Labels
Changelog: API Change Include in the "Changed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Contributor Monitoring
Status: Done
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

Strip _v2 from name in fake BackendV2 classes
7 participants
@shivalee12 @qiskit-bot @CLAassistant @coveralls @kdk @mtreinish @HuangJunye