Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix property and methods of BackendV2Converter #9502

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Bug fix property and methods of BackendV2Converter #9502

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39cd79d
fix property and methods of BackendV2Converter
to24toro Feb 1, 2023
1a0f77c
add reno
to24toro Feb 1, 2023
4a6bce9
Update releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml
nkanazawa1989 Feb 1, 2023
d59fe8e
Update releasenotes/notes/fix-backendv2converter-de342352cf882494.yaml
nkanazawa1989 Feb 1, 2023
4449eed
Merge branch 'main' into fix/backend_compat
mergify[bot] Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions qiskit/providers/backend_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,19 +266,19 @@ def dtm(self) -> float:

@property
def meas_map(self) -> List[List[int]]:
return self._config.dt
return self._config.meas_map

def drive_channel(self, qubit: int):
self._config.drive(qubit)
return self._config.drive(qubit)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, this is my bad. I switch back and forth between rust and python too much (Rust has an implicit return on the last line of a function without a semicolon)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly, the reason is very persuasive!


def measure_channel(self, qubit: int):
self._config.measure(qubit)
return self._config.measure(qubit)

def acquire_channel(self, qubit: int):
self._config.acquire(qubit)
return self._config.acquire(qubit)

def control_channel(self, qubits: Iterable[int]):
self._config.control(qubits)
return self._config.control(qubits)

def run(self, run_input, **options):
return self._backend.run(run_input, **options)