Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc links in README #343

Merged
merged 1 commit into from
Mar 16, 2024
Merged

fix doc links in README #343

merged 1 commit into from
Mar 16, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Mar 4, 2024

Follow-up to #89 and #309. These links are broken as of now, since they point to the stable documentation, which will only include the resources after the 0.2.0 release.

@pmeier pmeier added area: documentation 📖 Improvements or additions to documentation type: maintenance 🛠️ Day-to-day maintenance tasks labels Mar 4, 2024
@pmeier pmeier requested a review from pavithraes March 4, 2024 21:10
Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. I'll approve, but as you noted, we can merge this after the release.

@pmeier
Copy link
Member Author

pmeier commented Mar 5, 2024

No, we'll have to merge before, because the README is part of the release. Otherwise the links will not work on PyPI. I'll merge this right before cutting the release.

@pmeier pmeier added this to the 0.2.0 milestone Mar 13, 2024
@pmeier pmeier merged commit d3015ea into main Mar 16, 2024
4 checks passed
@pmeier pmeier deleted the readme-links branch March 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation type: maintenance 🛠️ Day-to-day maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants