Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix release notes link in project metadata #361

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix release notes link in project metadata #361

merged 1 commit into from
Mar 13, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Mar 13, 2024

  1. We renamed the file.
  2. We should point at the release notes of the current stable release rather than the dev version.

@pmeier pmeier added the area: documentation 📖 Improvements or additions to documentation label Mar 13, 2024
@pmeier pmeier requested a review from pavithraes March 13, 2024 12:52
@pmeier pmeier added this to the 0.2.0 milestone Mar 13, 2024
smokestacklightnin
smokestacklightnin reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@smokestacklightnin smokestacklightnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link works for me but it the page doesn't render properly for me. It gives a 404 not found response and the rendering looks broken

@pmeier
Copy link
Member Author

pmeier commented Mar 13, 2024

Sorry for not providing enough context. This is similar to #343. The link will work after the 0.2.0 release. Right now the correct link is https://ragna.chat/en/latest/references/release-notes/. When the release is published, what currently is in /latest will be moved to /stable and thus making the link in this PR valid.

However, in contrast to #343, this link is only in the pyproject.toml rather than in the very visible README. Thus, we can merge this already and don't need to wait until the last second.

@pmeier pmeier merged commit 859ad78 into main Mar 13, 2024
12 checks passed
@pmeier pmeier deleted the project-links branch March 13, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smokestacklightnin smokestacklightnin smokestacklightnin approved these changes

@pavithraes pavithraes Awaiting requested review from pavithraes

Assignees
No one assigned
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeier @smokestacklightnin