Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

[QMAPS 1737] Geoloc error modals #1088

Merged
merged 4 commits into from
May 25, 2021

Conversation

bbecquet
Copy link
Contributor

Description

Change some things about geolocation error modals:

  • new message wording
  • align modal content to the left
  • don't disable the geoloc map button after an error, so the user can get the error modal multiple times

Why

Better UX & "delight"

Screenshots

Before After
Screenshot_20210521-155938_Firefox Screenshot_20210521-155900_Firefox

@bbecquet bbecquet requested a review from xem May 21, 2021 14:14
Copy link
Contributor

@xem xem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the satellite emoji for the colored version?🛰️ (can be copied here: https://emojipedia.org/satellite/)
On your branch, all my browsers display the monochrome version:
image
Besides that it's great

@bbecquet
Copy link
Contributor Author

Can you please change the satellite emoji for the colored version

@xem Thank you! I did it. I thought this was there this emoji came from, but apparently not. On some device/os/browsers it looked fine for me, I thought this was normal it didn't work everywhere.
Not sure I understand everything about emojis :D… and I hope this change won't get lost throught Transifex.

@bbecquet bbecquet requested a review from xem May 25, 2021 13:13
@xem
Copy link
Contributor

xem commented May 25, 2021

No problem, now it works great on Windows.
Emoji are very weird creatures, when you use the monochrome version some browsers or OS can force the colored version and vice-versa, the kind of thing that can make us go crazy. ;)

@bbecquet bbecquet merged commit 473036a into Qwant:master May 25, 2021
@bbecquet bbecquet deleted the QMAPS-1737-geoloc-errors branch May 25, 2021 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants