This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Ensure the '_' i18n function keeps its name when built #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specify in the Webpack optimization config to not mangle (ie. replace by a generated name) the
_identifier, as it is used by the i18n script to spot translation strings in the bundle by analyzing the code.This uses the config of Terser (doc: https://github.com/terser/terser#mangle-options), the tool used by default by Webpack to optimize production code.
Why
Since #1088, some files use this function as exposed by a React hook, not as a global function. Translation strings used in this file were not part of the i18n extract anymore, because the
_const was renamed by Terser.Global identifiers are not mangled by default, which explains it didn't need a special config until now.
Comparison
In
public/build/javascript/bundle.js