This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Load Masq lib in separate chunk (fixes IE11) #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
changed the title
Julien-laville
previously requested changes
Apr 5, 2019
|
This way is much cleaner indeed ! |
|
The function isLoggedIn has been written to be synchronous, the dynamic loading of Masq makes every function of masq asynchronous, some changes are needed to make this work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masq lib bundle is not compatible with IE11.
With these changes, the Masq lib is loaded dynamically, so that webpack builds a separate chunk that will be used only if Masq integration is enabled.
This also reduces the default bundle size (from 160KB to 60KB gzipped).
In the future, it would probably be useful to ensure Masq keeps disabled on incompatible browsers, such as IE11.