This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
[ESLint] Lint test files #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import AutocompleteHelper from '../helpers/autocomplete'; | ||
| import ResponseHandler from '../helpers/response_handler'; | ||
| const configBuilder = require('@qwant/nconf-builder'); | ||
| const config = configBuilder.get(); |
There was a problem hiding this comment.
We should maybe enforce capitalized global consts. What do you think about it?
There was a problem hiding this comment.
Maybe, but in another PR :) There are a lot of things to improve on globals everywhere in the code, like stop polluting the window namespace. BTW, here this isn't really a global.
GuillaumeGomez
approved these changes
Jul 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply ESLint to test suite files, with slightly different rules:
describe,test, etc.)max-lenrule towarnonly, because tests are full of loooong selectors and I don't think it's crucial. What do you think?Why
No reason to have different coding practices on test code.