[ESLint] Lint test files

.eslintrc.json

@@ -78,5 +78,16 @@
         "prefer-const": ["error"],
         "no-var": "error",
         "eqeqeq": "error"
-    }
+    },
+    "overrides": [
+        {
+            "files": [
+                "tests/**/*.js"
+            ],
+            "env": {
+                "jest": true,
+                "node": true
+            }
+        }
+    ]
 }

package.json

@@ -16,8 +16,8 @@
     "msgmerge": "node local_modules/merge-po/index",
     "prepare": "npm run build-map-fonts && node build/before_build.js",
     "build-map-fonts": "node build/build_map_fonts.js",
-    "lint": "eslint src bin public/javascript build",
-    "lint-fix": "eslint --fix src bin public/javascript build"
+    "lint": "eslint src bin public/javascript build tests",
+    "lint-fix": "eslint --fix src bin public/javascript build tests"
   },
   "repository": {
     "type": "git",

tests/__data__/i18n.js

@@ -1,19 +1,19 @@
 module.exports = {
   i18nData: {
     message: {'fr test': 'en test'},
-    getPlural: function (n) {
-      return n > 1
-    }
+    getPlural: function(n) {
+      return n > 1;
+    },
   },
   date: {
     dayNames: [
-      "Sunday",
-      "Monday",
-      "Tuesday",
-      "Wednesday",
-      "Thursday",
-      "Friday",
-      "Saturday"
-    ]
-  }
-}
+      'Sunday',
+      'Monday',
+      'Tuesday',
+      'Wednesday',
+      'Thursday',
+      'Friday',
+      'Saturday',
+    ],
+  },
+};

tests/__mocks__/xml_http_mock.js

@@ -1,11 +1,11 @@
 const xhrMockClass = () => ({
-  open            : jest.fn()
-  , send            : function () {
-    this.response = '{}'
-    this.onload()
-  }
-  , setRequestHeader: jest.fn(),
+  open: jest.fn(),
+  send: function() {
+    this.response = '{}';
+    this.onload();
+  },
+  setRequestHeader: jest.fn(),
 
-})
+});
 
-window.XMLHttpRequest = jest.fn().mockImplementation(xhrMockClass)
+window.XMLHttpRequest = jest.fn().mockImplementation(xhrMockClass);

tests/integration.js

@@ -1,17 +1,17 @@
 module.exports = {
-  setupFilesAfterEnv: ["jest-extended"],
-  testMatch : [`${__dirname}/integration/tests/*.js`],
-  globalSetup : `${__dirname}/integration/server_start.js`,
-  globalTeardown : `${__dirname}/integration/server_close.js`,
-  testPathIgnorePatterns : ['/node_modules/'],
+  setupFilesAfterEnv: ['jest-extended'],
+  testMatch: [`${__dirname}/integration/tests/*.js`],
+  globalSetup: `${__dirname}/integration/server_start.js`,
+  globalTeardown: `${__dirname}/integration/server_close.js`,
+  testPathIgnorePatterns: ['/node_modules/'],
   'rootDir': __dirname + '/../',
   'verbose': true,
   'collectCoverage': false,
   'transform': {
     '\\.yml$': 'yaml-jest',
-    '\\.js?$': 'babel-jest'
+    '\\.js?$': 'babel-jest',
   },
-  globals : {
-    puppeteerArguments : ['--no-sandbox', '--disable-setuid-sandbox', '--disable-dev-shm-usage']
-  }
-}
+  globals: {
+    puppeteerArguments: ['--no-sandbox', '--disable-setuid-sandbox', '--disable-dev-shm-usage'],
+  },
+};

tests/integration/favorites_tools.js

@@ -1,4 +1,4 @@
-import {wait} from "./tools";
+import {wait} from './tools';
 
 /**
  * Prerequisite : Favorite Panel Must be open
@@ -7,14 +7,14 @@ import {wait} from "./tools";
  */
 export async function getFavorites(page) {
   return await page.evaluate(() => {
-    return Array.from(document.querySelectorAll('.favorite_panel__item__more_container')).map((e) => {
+    return Array.from(document.querySelectorAll('.favorite_panel__item__more_container')).map(e => {
       return {
         title: e.querySelector('.favorite_panel__item__title').innerText,
         desc: e.querySelector('.favorite_panel__item__desc').innerText,
-        icons: Array.from(e.querySelector('.favorite_panel__item__image.icon').classList.values())
-      }
-    })
-  })
+        icons: Array.from(e.querySelector('.favorite_panel__item__image.icon').classList.values()),
+      };
+    });
+  });
 }
 
 /**
@@ -25,6 +25,6 @@ export async function getFavorites(page) {
  * promise is resolved after animation
  */
 export async function toggleFavoritePanel(page) {
-  await page.click('.service_panel__item__fav')
-  await wait(500)
+  await page.click('.service_panel__item__fav');
+  await wait(500);
 }

tests/integration/helpers/autocomplete.js

@@ -1,59 +1,59 @@
-const SUGGEST_SELECTOR = '.autocomplete_suggestion'
-const CLEAR_BUTTON_SELECTOR = '#clear_button'
-const SEARCH_INPUT_SELECTOR = '#search'
+const SUGGEST_SELECTOR = '.autocomplete_suggestion';
+const CLEAR_BUTTON_SELECTOR = '#clear_button';
+const SEARCH_INPUT_SELECTOR = '#search';
 
 export default class AutocompleteHelper {
   constructor(page) {
-    this.page = page
+    this.page = page;
   }
 
   async typeAndWait(word) {
-    await this.page.keyboard.type(word)
-    await this.page.waitForSelector(SUGGEST_SELECTOR)
+    await this.page.keyboard.type(word);
+    await this.page.waitForSelector(SUGGEST_SELECTOR);
   }
 
   async pressDown() {
-    await this.page.keyboard.press('ArrowDown')
+    await this.page.keyboard.press('ArrowDown');
   }
 
   async hoverResult(position) {
-    await this.page.hover(`.autocomplete_suggestion:nth-child(${position})`)
+    await this.page.hover(`.autocomplete_suggestion:nth-child(${position})`);
   }
 
   async clickResult(position) {
-    await this.page.click(`.autocomplete_suggestion:nth-child(${position})`)
+    await this.page.click(`.autocomplete_suggestion:nth-child(${position})`);
   }
 
   async getSelectedElementPos() {
-    let suggestList = await this.getSuggestList()
-    return suggestList.findIndex((suggest) => {
-      return suggest.classes.some((cssClass) => {
-        return cssClass.trim() === 'selected'
-      })
-    })
+    const suggestList = await this.getSuggestList();
+    return suggestList.findIndex(suggest => {
+      return suggest.classes.some(cssClass => {
+        return cssClass.trim() === 'selected';
+      });
+    });
   }
 
   async getClearFieldButton() {
-    await this.page.waitForSelector(CLEAR_BUTTON_SELECTOR)
+    await this.page.waitForSelector(CLEAR_BUTTON_SELECTOR);
   }
 
   async clearField() {
-    return await this.page.click(CLEAR_BUTTON_SELECTOR)
+    return await this.page.click(CLEAR_BUTTON_SELECTOR);
   }
 
   async getSuggestList() {
-    return await this.page.evaluate((SUGGEST_SELECTOR) => {
-      let suggests = Array.from(document.querySelectorAll(SUGGEST_SELECTOR))
-      return suggests.map((suggest) => {
-        return {label : suggest.innerText, classes : Array.from(suggest.classList)}
-      })
-    }, SUGGEST_SELECTOR)
+    return await this.page.evaluate(SUGGEST_SELECTOR => {
+      const suggests = Array.from(document.querySelectorAll(SUGGEST_SELECTOR));
+      return suggests.map(suggest => {
+        return {label: suggest.innerText, classes: Array.from(suggest.classList)};
+      });
+    }, SUGGEST_SELECTOR);
   }
 
   async getSearchInputValue() {
-    return this.page.evaluate((SEARCH_INPUT_SELECTOR) => {
-      return document.querySelector(SEARCH_INPUT_SELECTOR).value
-    }, SEARCH_INPUT_SELECTOR)
+    return this.page.evaluate(SEARCH_INPUT_SELECTOR => {
+      return document.querySelector(SEARCH_INPUT_SELECTOR).value;
+    }, SEARCH_INPUT_SELECTOR);
   }
 
 

tests/integration/helpers/response_handler.js

@@ -1,42 +1,48 @@
 export default class ResponseHandler {
 
   constructor(page) {
-    this.preparedResponses = []
-    this.page = page
+    this.preparedResponses = [];
+    this.page = page;
   }
 
   static async init(page) {
-    const responseHandler = new ResponseHandler(page)
-    await responseHandler.prepareResponse()
-    return responseHandler
+    const responseHandler = new ResponseHandler(page);
+    await responseHandler.prepareResponse();
+    return responseHandler;
   }
 
   addPreparedResponse(response, query, options) {
-    let alreadySetResponse = this.preparedResponses.find((preparedResponse) => preparedResponse.query.toString() === query.toString())
-    if(!alreadySetResponse) {
-      this.preparedResponses.push({response, query, options})
+    const alreadySetResponse = this.preparedResponses.find(
+      preparedResponse => preparedResponse.query.toString() === query.toString()
+    );
+    if (!alreadySetResponse) {
+      this.preparedResponses.push({response, query, options});
     }
   }
 
   async prepareResponse() {
-    await this.page.setRequestInterception(true)
-    this.page.on('request', async (interceptedRequest) => {
-      let preparedResponse = this.preparedResponses.find(preparedResponse => {
-        return interceptedRequest.url().match(preparedResponse.query)
-      })
+    await this.page.setRequestInterception(true);
+    this.page.on('request', async interceptedRequest => {
+      const preparedResponse = this.preparedResponses.find(preparedResponse => {
+        return interceptedRequest.url().match(preparedResponse.query);
+      });
 
-      if(preparedResponse){
-        interceptedRequest.headers['Access-Control-Allow-Origin'] = '*'
-        let status = 200
-        if(preparedResponse.options) {
-          if(preparedResponse.options.status) {
-            status = preparedResponse.options.status
+      if (preparedResponse) {
+        interceptedRequest.headers['Access-Control-Allow-Origin'] = '*';
+        let status = 200;
+        if (preparedResponse.options) {
+          if (preparedResponse.options.status) {
+            status = preparedResponse.options.status;
           }
         }
-        await interceptedRequest.respond({status : status, body : JSON.stringify(preparedResponse.response), headers  : interceptedRequest.headers})
-        return
+        await interceptedRequest.respond({
+          status: status,
+          body: JSON.stringify(preparedResponse.response),
+          headers: interceptedRequest.headers}
+        );
+        return;
       }
-      interceptedRequest.continue()
-    })
+      interceptedRequest.continue();
+    });
   }
 }

tests/integration/server_close.js

@@ -1,3 +1,3 @@
-module.exports = async function () {
-  global.appServer.close()
-}
+module.exports = async function() {
+  global.appServer.close();
+};