Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test fetchpriority option for modulepreload on 1.7.3 (DO NOT MERGE) #6826

Closed

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Aug 26, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

As discussed in https://discord.com/channels/842438759945601056/1276861655833383034/1277680025398804491

TLDR: I need this PR to test modulepreload with fetchpriority to low on qwik UI on a production setup to see if it fixes FCP and LCP issues with modulepreload.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@maiieul maiieul requested review from a team as code owners August 26, 2024 19:44
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 0510067

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul force-pushed the test-fetchpriority-with-modulepreload branch from caded4c to 6950983 Compare August 26, 2024 19:46
This reverts commit c7d8805.
@maiieul maiieul force-pushed the test-fetchpriority-with-modulepreload branch from 6950983 to fe5590a Compare August 26, 2024 19:55
@maiieul maiieul force-pushed the test-fetchpriority-with-modulepreload branch from fe5590a to 0510067 Compare August 27, 2024 11:11
@maiieul maiieul closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant