-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: test fetchpriority option for modulepreload on 1.7.3 (DO NOT MERGE) #6826
Closed
maiieul
wants to merge
290
commits into
QwikDev:main
from
maiieul:test-fetchpriority-with-modulepreload
Closed
chore: test fetchpriority option for modulepreload on 1.7.3 (DO NOT MERGE) #6826
maiieul
wants to merge
290
commits into
QwikDev:main
from
maiieul:test-fetchpriority-with-modulepreload
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0510067 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
maiieul
force-pushed
the
test-fetchpriority-with-modulepreload
branch
from
August 26, 2024 19:46
caded4c
to
6950983
Compare
This reverts commit d589fac.
This reverts commit 86d6378.
This reverts commit 568132c.
This reverts commit 7b2ee07.
This reverts commit 42880cf.
This reverts commit 99296ea.
This reverts commit f5fc443.
This reverts commit 3c30ecd.
This reverts commit 5a3d975.
This reverts commit 92ed808.
This reverts commit ae68a60.
This reverts commit d73af62.
This reverts commit b3925d5.
This reverts commit 5250dc5.
This reverts commit c7d8805.
This reverts commit e8bd894.
This reverts commit 99d6db4.
…n guide (QwikDev#6730)" This reverts commit 14b27c8.
This reverts commit ee8b9c5.
This reverts commit 83d9185.
This reverts commit 62dd297.
This reverts commit 28dda10.
This reverts commit e2cc179.
maiieul
force-pushed
the
test-fetchpriority-with-modulepreload
branch
from
August 26, 2024 19:55
6950983
to
fe5590a
Compare
This reverts commit 1d79edb.
This reverts commit 517719b.
This reverts commit 71c0c24.
This reverts commit 5595af1.
This reverts commit 0b6752d.
This reverts commit 6a7e2f3.
This reverts commit 4e1f31e.
This reverts commit e3c868c.
This reverts commit 4f40c29.
This reverts commit c69495b.
This reverts commit 8125f6b.
This reverts commit dd70f6b.
This reverts commit f6020c3.
This reverts commit 880f5bc.
This reverts commit 88c8004.
This reverts commit 79dd5a5.
This reverts commit 977b935.
This reverts commit 3805951.
This reverts commit b5b445b.
This reverts commit e5476a3.
This reverts commit 30560ea.
This reverts commit 4e67d65.
)" This reverts commit 563ddc5.
This reverts commit 49d4c5d.
This reverts commit e4eb2c3.
This reverts commit 9292a59.
This reverts commit 3c5e5a7.
maiieul
force-pushed
the
test-fetchpriority-with-modulepreload
branch
from
August 27, 2024 11:11
fe5590a
to
0510067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
As discussed in https://discord.com/channels/842438759945601056/1276861655833383034/1277680025398804491
TLDR: I need this PR to test modulepreload with fetchpriority to low on qwik UI on a production setup to see if it fixes FCP and LCP issues with modulepreload.
Checklist:
pnpm change
and documented my changes