Serverside Rui

[uniboi]

Add documentation for RUI which was added with R2Northstar/NorthstarMods#435

Closes #65

[uniboi]

images aren't showing and idk why

[F1F7Y]

Looks good

[GeckoEidechse]

Adding additional example code next to the docs @F1F7Y provided is dope af <3

I'd just update them so they (roughly) produce the output shown in the GIFs. Doesn't need to be super accurate but at least the text should be the same IMO ^^

[GeckoEidechse]

Discord link to (incomplete) list of RUI images: https://discord.com/channels/920776187884732556/1001559004889223258/1001559007623921694

(Not needed for this PR but thought I'd just drop it somewhere to find again and maybe add with new PR)

[SenorGeese]

@uniboi did you make those gifs/pngs?

[uniboi]

no they're from the pr description by @F1F7Y

[SenorGeese]

Time to learn how to do this custom RUI so i can get my own gifs. Looks like they work with just a local mod so that's good.

[uniboi]

I posted a demo mod in the serverside Rui pr

[SenorGeese]

Found a bug, dummy related, probably more related to desync though.

I was making the the examples for implementation of Geckos suggestions.

I was adjusting timings and added more messages. I changed the RUI_TEST_DURATION to 5.

Bug Evidence

NSSendPopUpMessageToPlayer( player, "These are a little difficult to see." ); This is the only function with the string with "These are a little difficult to see".

File

rui_demo.txt

Converted to .txt via rename because github doesn't like .nut files.

What I think ig

Starting at line 32, we send line 32 func, since CONST is 5 sec, skips over line 36 func, but keeps the func, the game uses the function being SendInfoMessage, but because the wait being only 3 seconds, the script moved onto line 40 but ignores the PopUpMessage function and just usings it's string. Idk anything though so.

[SenorGeese]

@F1F7Y sorry to do this to you ig ^
goodnight

[F1F7Y]

1. What
2. Probably better to make an issue on NorthstarMods to not clutter up this convo

[GeckoEidechse]

Found a bug, dummy related, probably more related to desync though.

Uh, what exactly is the bug? It skips a message or what?

I was making the examples for implementation of Geckos suggestions.

Just FYI, I suggested updating the text to match the GIFs, not the other way round cause that's easier than having to redo all the GIFs :P

[SenorGeese]

The bug is that is using the string from a PopUp message but uses the InfoMessage function.
NSSendPopUpMessageToPlayer( player, "These are a little difficult to see." ); this is SendPopUpMessage, not what displayed in my game being SendInfoMessage
That is the bug @F1F7Y and @GeckoEidechse

and Gecko. I'd rather update the gifs too because the original gifs seemed too random and all over the place. I can probably do that instead if i have to though.

[F1F7Y]

The bug is that is using the string from a PopUp message but uses the InfoMessage function. NSSendPopUpMessageToPlayer( player, "These are a little difficult to see." ); this is SendPopUpMessage, not what displayed in my game being SendInfoMessage That is the bug @F1F7Y and @GeckoEidechse

and Gecko. I'd rather update the gifs too because the original gifs seemed too random and all over the place. I can probably do that instead if i have to though.

So basically what's described here: R2Northstar/NorthstarMods#524

[SenorGeese]

It's a little unclear but looks like the same issue, yes.

[emma-miler]

@GeckoEidechse since you were the one reviewing this before, can you give me a quick status report on this PR?

[GeckoEidechse]

@GeckoEidechse since you were the one reviewing this before, can you give me a quick status report on this PR?

No update. Still waiting on @uniboi to implement requested changes.

[SenorGeese]

Okay well I got around the bug. Info messages are just buggier than the rest.
Here is the script I'll be getting the new gifs/images from.
rui_demo.nut.txt

[GeckoEidechse]

Good enough for me. Ready to merge from my side.

[SenorGeese]

Should I still update it with my/the better examples?

[laundmo]

Sure, feel free to make a new PR - mainly wanted to get this merged for #100