-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serverside RUI, but it doesn't stink ( hopefully ) #435
Serverside RUI, but it doesn't stink ( hopefully ) #435
Conversation
contains a sample mod that I used for reviewing #392. Anyone reviewing this PR feel free to modify it to work with this PR. It will NOT work out of the box with this version of serverside RUI! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine and tested all features hud elements, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked fine in testing
(many thanks to @uniboi for the demo mod <3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spaces between the numbers and the bracket are not always in Respawn code but Gecko wants them to be there. The ones between the numbers themselves are always there.
Pls fix this as a batch commit
Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Me when firefox cached the page and I didn't see the reviews :) |
this worsens readability and I've seen respawn formatting vectors as |
Counterpoint: |
ok I changed my mind I just used |
you can also |
Someone giving the suggested changes a final look and test maybe would be appreciated <3 |
What changes are you referring to? I thought only formatting has been changed so the test mod I sent earlier should still work fine? |
The commits that were added since the last review basically. I think it was just formatting as you said (don't have the setup rn to check). For testing, just running newest version of PR with your mod again should be enough. It's just to make sure there weren't any accidental errors syntax or whatever added since last change. Usually I'd do this myself but I'm on holiday atm :P |
|
Aight, Imma put my trust in you :P Time to merge :D |
Welp, it's been fun not having to cherry-pick commits for patch releases ._. |
WOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO |
* Serverside polls * reset table so mods can wait for response * large message * popup message * announcement * info * status * fix uniboi crash * no need to return id * among * typo * Formatting * bruh * takyon doesn't know how to finish a review * Formatting * Do you not know how to finish a review or what * You should look at gamemode_aitdm for some funky formatting :) * Formatting * Formatting * Finally a good suggestion * fix client misinterpreting assets
Allows servers to use rui presets on clients, clients dont need to update to play
Polls
Large message
Info
PopUp
Announcement
Status