Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverside RUI, but it doesn't stink ( hopefully ) #435

Merged
merged 22 commits into from
Jul 26, 2022
Merged

Serverside RUI, but it doesn't stink ( hopefully ) #435

merged 22 commits into from
Jul 26, 2022

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Jul 19, 2022

Allows servers to use rui presets on clients, clients dont need to update to play

Polls

void function NSCreatePollOnPlayer( entity player, string header, array<string> options, float duration );
int function NSGetPlayerResponse( entity player );

poll-image

Large message

void function NSSendLargeMessageToPlayer( entity player, string title, string description, float duration, string image );

large

Info

void function NSSendInfoMessageToPlayer( entity player, string text );

info

PopUp

void function NSSendPopUpMessageToPlayer( entity player, string text );

popup

Announcement

void function NSSendAnnouncementMessageToPlayer( entity player, string title, string description, vector color, int priority, int style );

announcement

Status

void function NSCreateStatusMessageOnPlayer( entity player, string title, string description, string id );
void function NSEditStatusMessageOnPlayer( entity player, string title, string description, string id  );
void function NSDeleteStatusMessageOnPlayer( entity player, string id  );

2status

@F1F7Y F1F7Y marked this pull request as draft July 19, 2022 14:53
@F1F7Y F1F7Y marked this pull request as ready for review July 19, 2022 16:24
@GeckoEidechse
Copy link
Member

GeckoEidechse.RuiDemo.zip

contains a sample mod that I used for reviewing #392. Anyone reviewing this PR feel free to modify it to work with this PR. It will NOT work out of the box with this version of serverside RUI!

Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd.RuiDemo.zip

Code looks fine and tested all features hud elements, looks good to me!

Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine in testing

(many thanks to @uniboi for the demo mod <3)

Copy link
Contributor

@RoyalBlue1 RoyalBlue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spaces between the numbers and the bracket are not always in Respawn code but Gecko wants them to be there. The ones between the numbers themselves are always there.

Pls fix this as a batch commit

F1F7Y and others added 9 commits July 23, 2022 15:12
Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
@F1F7Y
Copy link
Member Author

F1F7Y commented Jul 23, 2022

Me when firefox cached the page and I didn't see the reviews :)

@uniboi
Copy link
Contributor

uniboi commented Jul 23, 2022

The spaces between the numbers and the bracket are not always in Respawn code but Gecko wants them to be there. The ones between the numbers themselves are always there.

Pls fix this as a batch commit

this worsens readability and I've seen respawn formatting vectors as <x, y, z> more often than < x, y, z >

@ASpoonPlaysGames
Copy link
Contributor

The spaces between the numbers and the bracket are not always in Respawn code but Gecko wants them to be there. The ones between the numbers themselves are always there.
Pls fix this as a batch commit

this worsens readability and I've seen respawn formatting vectors as <x, y, z> more often than < x, y, z >

Counterpoint: <x, y, z> creates a compile error if x is negative so i prefer the other option

@uniboi
Copy link
Contributor

uniboi commented Jul 23, 2022

ok I changed my mind I just used <(x), y z> for no reason whatsoever when a better option exists

@F1F7Y
Copy link
Member Author

F1F7Y commented Jul 23, 2022

you can also vector(x, y, z) iirc

@GeckoEidechse GeckoEidechse added the needs code review Changes from PR still need to be reviewed in code label Jul 25, 2022
@GeckoEidechse
Copy link
Member

Someone giving the suggested changes a final look and test maybe would be appreciated <3

@GeckoEidechse GeckoEidechse added the needs testing Changes from the PR still need to be tested label Jul 25, 2022
@uniboi
Copy link
Contributor

uniboi commented Jul 26, 2022

Someone giving the suggested changes a final look and test maybe would be appreciated <3

What changes are you referring to? I thought only formatting has been changed so the test mod I sent earlier should still work fine?

@GeckoEidechse
Copy link
Member

Someone giving the suggested changes a final look and test maybe would be appreciated <3

What changes are you referring to? I thought only formatting has been changed so the test mod I sent earlier should still work fine?

The commits that were added since the last review basically. I think it was just formatting as you said (don't have the setup rn to check). For testing, just running newest version of PR with your mod again should be enough. It's just to make sure there weren't any accidental errors syntax or whatever added since last change. Usually I'd do this myself but I'm on holiday atm :P

@uniboi
Copy link
Contributor

uniboi commented Jul 26, 2022

image
@GeckoEidechse everything works now and images are fixed. This is imo ready to merge

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jul 26, 2022
@GeckoEidechse
Copy link
Member

image @GeckoEidechse everything works now and images are fixed. This is imo ready to merge

Aight, Imma put my trust in you :P

Time to merge :D

@GeckoEidechse GeckoEidechse merged commit e591885 into R2Northstar:main Jul 26, 2022
@GeckoEidechse
Copy link
Member

Welp, it's been fun not having to cherry-pick commits for patch releases ._.

@x3Karma
Copy link
Contributor

x3Karma commented Jul 26, 2022

WOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO

JMM889901 pushed a commit to JMM889901/NorthstarMods that referenced this pull request Aug 12, 2024
* Serverside polls

* reset table so mods can wait for response

* large message

* popup message

* announcement

* info

* status

* fix uniboi crash

* no need to return id

* among

* typo

* Formatting

* bruh

* takyon doesn't know how to finish a review

* Formatting

* Do you not know how to finish a review or what

* You should look at gamemode_aitdm for some funky formatting :)

* Formatting

* Formatting

* Finally a good suggestion

* fix client misinterpreting assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants