Allow rpaks to use starpaks that are in the mod's folder #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did the reading from the rpak file thing, as far as i'm concerned this is complete and ready |
|
works as intended, tested myself. see clip for example |
IcePixelx
suggested changes
Oct 6, 2022
|
docker: |
pg9182
approved these changes
Oct 8, 2022
BobTheBob9
requested changes
Oct 21, 2022
BobTheBob9
approved these changes
Oct 21, 2022
BobTheBob9
requested changes
Oct 21, 2022
BobTheBob9
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the starpaks had to be inside the r2 directory somewhere, this PR adds a field to the rpak.json that registers starpak paths as being relative to the mod/paks directory instead.
I'm making this PR now, however I am going to try and read the starpak paths from the rpak header instead of using the json here, so yeah