Fix issues of restriction of chat message charset #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeckoEidechse
approved these changes
Jan 6, 2023
NoCatt
approved these changes
Jan 6, 2023
GeckoEidechse
pushed a commit
that referenced
this pull request
Jan 6, 2023
BobTheBob9
pushed a commit
that referenced
this pull request
Jan 20, 2023
Pedantic fix for previous commit (3cfd6f9) (use if-else instead of if)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regressions introduced with #389 (4df4758).
Previous implementation could cause crashes due to null pointer dereference and removed all UTF-8 characters.
Current implementation fixes aforementioned null pointer dereference, preserves valid UTF-8 sequences while removing invalid ones (invalid ones won't crash). Furthermore, duplicated code was moved out to a common file.
Also allows
:as suggested by cpdt analogous to here: https://github.com/R2Northstar/NorthstarLauncher/blob/main/NorthstarDLL/client/localchatwriter.cpp#L414