Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TFFA from crashing when a player leaves during the intro sequence #434

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Fix TFFA from crashing when a player leaves during the intro sequence #434

merged 2 commits into from
Jul 21, 2022

Conversation

x3Karma
Copy link
Contributor

@x3Karma x3Karma commented Jul 18, 2022

mog.

JMM889901
JMM889901 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@JMM889901 JMM889901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not also be worth just doing isvalid on respawnastitan?

@x3Karma
Copy link
Contributor Author

x3Karma commented Jul 20, 2022

Would it not also be worth just doing isvalid on respawnastitan?

you probably could put isvalid checks on respawnastitan or respawnaspilot as well.

GeckoEidechse
GeckoEidechse approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug and fix confirmed in testing.

@GeckoEidechse GeckoEidechse merged commit ef30d11 into R2Northstar:main Jul 21, 2022
@x3Karma x3Karma deleted the patch-3 branch July 21, 2022 00:45
JMM889901 pushed a commit to JMM889901/NorthstarMods that referenced this pull request Aug 12, 2024
@x3Karma @JMM889901
Fix TFFA from crashing when a player leaves during the intro sequence (…
01d2a64 
…R2Northstar#434)

* Fix TFFA from crashing when a player leaves during the intro sequence
* Fix Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMM889901 JMM889901 JMM889901 approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@RoyalBlue1 RoyalBlue1 RoyalBlue1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@x3Karma @RoyalBlue1 @GeckoEidechse @JMM889901